kicad-developers team mailing list archive
-
kicad-developers team
-
Mailing list archive
-
Message #32501
Re: P-Cad patch
-
To:
Eldar Khayrullin <eldar.khayrullin@xxxxxxx>
-
From:
Maciej Suminski <maciej.suminski@xxxxxxx>
-
Date:
Sun, 17 Dec 2017 11:33:18 +0100
-
Authentication-results:
spf=pass (sender IP is 188.184.36.48) smtp.mailfrom=cern.ch; lists.launchpad.net; dkim=none (message not signed) header.d=none;lists.launchpad.net; dmarc=bestguesspass action=none header.from=cern.ch;
-
Cc:
KiCad Developers <kicad-developers@xxxxxxxxxxxxxxxxxxx>
-
In-reply-to:
<1513494543.1616.0@smtp.mail.ru>
-
Spamdiagnosticmetadata:
NSPM
-
Spamdiagnosticoutput:
1:99
-
User-agent:
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0
Hi Eldar,
No, you are not in a spam list. Unfortunately, there are times when I
cannot work on KiCad, so it happens that a patch is not merged
instantly. I have never committed a patch without reading and testing it
first and it takes time too. Please be patient.
Having said that, I have just read your patches and tested them with a
limited set of P-Cad files I have. I do not have P-Cad to verify the
imported results, so I simply trust you about the changes. Thank you for
your contribution, your patches have been merged.
Regards,
Orson
On 12/17/2017 08:09 AM, Eldar Khayrullin wrote:
> Am I in a spam list?
>
> В Суббота, 16 дек. 2017 в 3:33 П. П., Eldar Khayrullin
> <eldar.khayrullin@xxxxxxx> написал:
>> Rebased patches.
>>
>> В Четверг, 14 дек. 2017 в 9:00 П. П., Maciej Suminski
>> <maciej.suminski@xxxxxxx> написал:
>>> Thank you for quick tests, I have just pushed both patches to the master
>>> branch. Regarding the previous patches - I checked the bug reports
>>> tagged 'pcad' and browsed the mailing list, but I could not find any
>>> patch that had not been applied. Would you point me to them?
>>>
>>> Regards,
>>> Orson
>>>
>>> On 12/14/2017 06:09 PM, Eldar Khayrullin wrote:
>>>> Hi. I tested your patch. But found another one warning (see my patch).
>>>> What about my previous patches for PCAD import improvement?
>>>>
>>>> В Четверг, 14 дек. 2017 в 6:11 П. П., Maciej Suminski
>>>> <maciej.suminski@xxxxxxx> написал:
>>>>> Hi Eldar,
>>>>>
>>>>> I have an impression that you are one of the main P-Cad importer
>>>>> users.
>>>>> Would you test the attached patch? It fixes a number of warnings
>>>>> in the
>>>>> P-Cad importer plugin, but I do not have any files to verify the
>>>>> code.
>>>>>
>>>>> Thank you,
>>>>> Orson
>>>>
>
Follow ups
References