kicad-developers team mailing list archive
-
kicad-developers team
-
Mailing list archive
-
Message #32554
Re: [PATCH] Correct bus junction behavior
Thanks for the update. I will defer this until the version 6
development is opened.
On 12/20/2017 11:03 AM, Jon Evans wrote:
> For V5, the color issue would have to be resolved in a different way
> than I was proposing, since the connectivity information won't be there.
>
> I think it might be best to hold off on this patch until after V6
> development is open since it is not a major bug fix and it would be
> prudent to do a fair amount of testing that this doesn't impact netlisting.
>
> -Jon
>
> On Wed, Dec 20, 2017 at 10:24 AM, Wayne Stambaugh <stambaughw@xxxxxxxxx
> <mailto:stambaughw@xxxxxxxxx>> wrote:
>
> What is the probability that this breaks any existing schematics and how
> soon could the color issue be resolved? If the risk of breaking
> existing schematics is very low and the color issue can be resolved
> reasonably soon, then I would consider merging for the stable 5 version.
> Otherwise, we should hold off until the we open version 6 for
> development.
>
> Cheers,
>
> Wayne
>
> On 12/20/2017 8:34 AM, Jon Evans wrote:
> > This patch is essential for my connectivity work (but that's not a V5
> > thing...)
> > It would be quite easy for me to implement the color thing as part of
> > the connectivity changes (since the junction would be able to know if it
> > was connected to buses or not)
> >
> > -Jon
> >
> > On Wed, Dec 20, 2017 at 8:18 AM, Wayne Stambaugh <stambaughw@xxxxxxxxx <mailto:stambaughw@xxxxxxxxx>
> > <mailto:stambaughw@xxxxxxxxx <mailto:stambaughw@xxxxxxxxx>>> wrote:
> >
> > Seth,
> >
> > Technically this is a new feature since KiCad has never used junction
> > indicators on buses in the past so I'm hesitant to merge this for
> > version 5. I do like the dragging of buses that this patch provides.
> > I'm also thinking that the bus junction color should be the same color
> > as the bus color rather than the wire color but that may be difficult
> > given our coloring scheme for schematic objects. Does anyone else have
> > any opinions on this patch?
> >
> > Cheers,
> >
> > Wayne
> >
> >
> > On 12/14/2017 6:24 PM, Seth Hillbrand wrote:
> > > The attached patch adds junction management to buses in addition
> > to wires.
> > >
> > > Of note, this also adds buses to the draggable junctions collection.
> > > Now that junctions are managed internally, it makes sense to allow any
> > > collection with a junction to allow draggable junctions.
> > >
> > > -Seth
> > >
> > >
> > > _______________________________________________
> > > Mailing list: https://launchpad.net/~kicad-developers
> <https://launchpad.net/~kicad-developers>
> > <https://launchpad.net/~kicad-developers
> <https://launchpad.net/~kicad-developers>>
> > > Post to : kicad-developers@xxxxxxxxxxxxxxxxxxx
> <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
> > <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx
> <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>>
> > > Unsubscribe : https://launchpad.net/~kicad-developers
> <https://launchpad.net/~kicad-developers>
> > <https://launchpad.net/~kicad-developers
> <https://launchpad.net/~kicad-developers>>
> > > More help : https://help.launchpad.net/ListHelp
> <https://help.launchpad.net/ListHelp>
> > <https://help.launchpad.net/ListHelp
> <https://help.launchpad.net/ListHelp>>
> > >
> >
> > _______________________________________________
> > Mailing list: https://launchpad.net/~kicad-developers
> <https://launchpad.net/~kicad-developers>
> > <https://launchpad.net/~kicad-developers
> <https://launchpad.net/~kicad-developers>>
> > Post to : kicad-developers@xxxxxxxxxxxxxxxxxxx
> <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
> > <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx
> <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>>
> > Unsubscribe : https://launchpad.net/~kicad-developers
> <https://launchpad.net/~kicad-developers>
> > <https://launchpad.net/~kicad-developers
> <https://launchpad.net/~kicad-developers>>
> > More help : https://help.launchpad.net/ListHelp
> <https://help.launchpad.net/ListHelp>
> > <https://help.launchpad.net/ListHelp
> <https://help.launchpad.net/ListHelp>>
> >
> >
>
>
Follow ups
References