kicad-developers team mailing list archive

[Nick Østergaard <oe.nick@xxxxxxxxx>]

Hi Wayne,

Thank you for fixing [Bug 1739910] Configure paths are missing in eeschema

But I propose to move the menu item to directly after the lib table menu
option as it is in pcbnew. And also use the same icon as everywhere else.

The attached patch does exactly that.

Regards
Nick Østergaard

From 98ea474d9719c26f7345b3caf15124eaa6047ac9 Mon Sep 17 00:00:00 2001
From: Nick ?stergaard <oe.nick@xxxxxxxxx>
Date: Mon, 25 Dec 2017 00:22:46 +0100
Subject: [PATCH] Use same path icon for the Configure Paths menu option

Also move the path configure item above the General Options to align
better with the menu in pcbnew.
---
 eeschema/menubar.cpp | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/eeschema/menubar.cpp b/eeschema/menubar.cpp
index aba15417a..805895cbe 100644
--- a/eeschema/menubar.cpp
+++ b/eeschema/menubar.cpp
@@ -635,6 +635,13 @@ static void preparePreferencesMenu( SCH_EDIT_FRAME* aFrame, wxMenu* aParentMenu
                  _( "Edit the global and project symbol library tables (list of active libraries)." ),
                  KiBitmap( library_table_xpm ) );
 
+    // Path configuration edit dialog.
+    AddMenuItem( aParentMenu,
+                 ID_PREFERENCES_CONFIGURE_PATHS,
+                 _( "Configure &Paths" ),
+                 _( "Edit path configuration environment variables" ),
+                 KiBitmap( path_xpm ) );
+
     // Options (Preferences on WXMAC)
 #ifdef __WXMAC__
     aParentMenu->Append( wxID_PREFERENCES );
@@ -646,13 +653,6 @@ static void preparePreferencesMenu( SCH_EDIT_FRAME* aFrame, wxMenu* aParentMenu
                  KiBitmap( preference_xpm ) );
 #endif // __WXMAC__
 
-    // Path configuration edit dialog.
-    AddMenuItem( aParentMenu,
-                 ID_PREFERENCES_CONFIGURE_PATHS,
-                 _( "Configure &Paths" ),
-                 _( "Edit path configuration environment variables" ),
-                 KiBitmap( editor_xpm ) );
-
     // Language submenu
     aParentMenu->AppendSeparator();
     Pgm().AddMenuLanguageList( aParentMenu );
-- 
2.15.1