← Back to team overview

kicad-developers team mailing list archive

Re: Modeless dialog action buttons

 

Hi Fabrizio,

Yes, the dialog pictured is the one I meant.  On my machine it has “Cancel” instead of “Close”.  (Or perhaps your screen shot was taken after fixing it?)

As for the other buttons, they should definitely be verbs, not nouns.  (Generate Drill File, etc.)

Cheers,
Jeff.

> On 28 Dec 2017, at 14:04, Fabrizio Tappero <fabrizio.tappero@xxxxxxxxx> wrote:
> 
> Hi,
> 
> Jeff, when you say "Drill File Generation"... what do you mean?
> 
> talking about button labels (see below) I have an issue with "Drill File" as well as "Map File" and "Report File". I feel they should be changed into "Generate Drill File" and "Generate Map File", etc.
> 
> Am I wrong? Suggestions?
> 
> Cheers
> Fabrizio
> 
> 
> 
> <image.png>
> 
> On Sun, Dec 24, 2017 at 12:24 AM, Bernhard Stegmaier <stegmaier@xxxxxxxxxxxxx <mailto:stegmaier@xxxxxxxxxxxxx>> wrote:
> … same for the new remap dialog in eeschema.
> 
> Regards,
> Bernhard
> 
> > On 23. Dec 2017, at 17:28, Andy Peters <devel@xxxxxxxxx <mailto:devel@xxxxxxxxx>> wrote:
> >
> >
> >> On Dec 23, 2017, at 9:17 AM, Jeff Young <jeff@xxxxxxxxx <mailto:jeff@xxxxxxxxx>> wrote:
> >>
> >> Found another one: Drill Files Generation.
> >
> > In pcbnew, the netlist import dialog has a “cancel” button, which is useful for when you decide you don’t want to do the import, but once the import has completed, that button should change to “close.”
> >
> > I’m not sure that the position of the “cancel” button in that dialog makes sense; perhaps it should be at the bottom of the buttons.
> >
> > -a
> >
> >
> >
> >>
> >>> On 21 Dec 2017, at 14:33, Wayne Stambaugh <stambaughw@xxxxxxxxx <mailto:stambaughw@xxxxxxxxx>> wrote:
> >>>
> >>> They should be "Close".  I'll will try to get them fixed soon.
> >>>
> >>> On 12/21/2017 8:00 AM, Jeff Young wrote:
> >>>> There are several modeless dialogs in pcbnew (for instance, Exchange Footprint and Plot) which have action buttons and a “Cancel” button.
> >>>>
> >>>> These shouldn’t be called “Cancel” as they don’t cancel the action.  They should be either “Done” or “Close”.
> >>>>
> >>>> Comments?
> >>>>
> >>>> (Resending to fix bogus thread link.)
> >>>> _______________________________________________
> >
> > _______________________________________________
> > Mailing list: https://launchpad.net/~kicad-developers <https://launchpad.net/~kicad-developers>
> > Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
> > Unsubscribe : https://launchpad.net/~kicad-developers <https://launchpad.net/~kicad-developers>
> > More help   : https://help.launchpad.net/ListHelp <https://help.launchpad.net/ListHelp>
> 
> 
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers <https://launchpad.net/~kicad-developers>
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
> Unsubscribe : https://launchpad.net/~kicad-developers <https://launchpad.net/~kicad-developers>
> More help   : https://help.launchpad.net/ListHelp <https://help.launchpad.net/ListHelp>
> 
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp


References