← Back to team overview

kicad-developers team mailing list archive

Re: small heads-up...

 

That section looks good in the master repo
https://github.com/KiCad/kicad-source-mirror/blob/f7ab50f791b030eb3f4facbf58c44b101a141594/eeschema/dialogs/dialog_bom_editor.cpp#L255

Maybe you have pulled some changes where it made a bad merge?

2017-12-29 16:34 GMT+01:00 Marco Ciampa <ciampix@xxxxxxxxx>:

> On Fri, Dec 29, 2017 at 10:10:49AM -0500, Kevin Cozens wrote:
> > On 2017-12-29 09:50 AM, Marco Ciampa wrote:
> > >Open and see for yourself...
> > >
> > >eeschema/dialogs/dialog_bom_editor.cpp:263: warning: unterminated
> string literal
> >
> > I don't immediately see why it would say that. I do see that the line
> has a
> > typo. The string in line 262 starts with "Symbo Table" instead of "Symbol
> > Table".
>
> I may be wrong but what I see is a partially commented source...
>
>
> //     if( m_bom->GetColumnGrouping() )
> //     {
> //         title.Printf ( _( "Symbol
>  Table - %u symbols in %u groups" ),
>                        m_bom->ComponentCount(),
>                        (unsigned int) m_bom->Groups.size() );
>     }
>     else
>         title.Printf ( _( "Symbol Table - %u components" ),
>                        m_bom->ComponentCount() );
>
>
> This to me seems a bit odd...
>
> --
>
>
> Marco Ciampa
>
> I know a joke about UDP, but you might not get it.
>
> ------------------------
>
>  GNU/Linux User #78271
>  FSFE fellow #364
>
> ------------------------
>
>
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>

Follow ups

References