kicad-developers team mailing list archive

[Adam Wolf <adamwolf@xxxxxxxxxxxxxxxxxxxx>]

I think the main reason why this happens is that most of those patches
are not created by KiCad devs, but rather taken from upstream mailing
lists, and I have always just preserved the patch as is, but I don't
have a strong opinion on keeping it like it is or changing it to be
more consistent.

I don't mind how it would get changed, as long as, if it gets changed,
it gets more consistent between the different patches and between the
patches and the docs.

Adam Wolf

On Fri, Dec 29, 2017 at 2:37 PM, Wayne Stambaugh <stambaughw@xxxxxxxxx> wrote:
> Any of our osx devs have an opinion on this?  It doesn't impact me so I
> would rather the devs who have to use this make the call.
>
> On 12/29/2017 03:33 PM, Anton Shevchenko wrote:
>> Hi all,
>>
>> Looking through the code style guide (i'm new here) I didn't find a word about how a patch file should reference source code file. By patch file I mean *.patch file located in kicad/patches folder.
>>
>> Being on macOS I'm trying to apply all the patches required for building wxWidgets and have found that there are 2 different styles in use.
>> First style references source code files without prefix. To apply such a patch one has to run 'patch -p0'.
>> The other style uses a/ and b/ prefixes which is used with 'patch -p1' option.
>> In my opinion the last one is more common (and if you run 'git diff' you will see a/ and b/ prefixes).
>>
>> I would like to fix macOS patches stuff to be able to actually follow the guide (http://docs.kicad-pcb.org/doxygen/md_Documentation_development_compiling.html#build_osx) in order to build KiCad for macOS.
>>
>> Any comments?
>>
>
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp