← Back to team overview

kicad-developers team mailing list archive

Re: Patches consistency

 

It won’t be that easy to switch to wx3.1:
* They added (previously non-existing) overlay code. It does basically work but is slow as hell - and quite different from the overlay patch we have. I didn’t have time yet to see whether it is more easy to fix or just replace by our patch (which is also in the bug tracker, don’t know why they didn’t take it as is).
* Currently all dialogs don’t close when you hit enter in a text box. I also didn’t have time to investigate… :(

And still some other patches needed (e.g., Retina support).


Regards,
Bernhard

> On 30. Dec 2017, at 13:04, Jeff Young <jeff@xxxxxxxxx> wrote:
> 
> Some of them are already up-stream, but we would have to move to wxWidgets 3.1 (when it comes out in a month or so) to get them.  The wxWidgets folks won’t back-port header changes, for instance.
> 
> I don’t know how many of the existing patches are in 3.0.3, but I don’t think very many (IIRC only 1 or 2 of them failed when I tried to apply them to 3.0.3).
> 
> Cheers,
> Jeff.
> 
> 
>> On 30 Dec 2017, at 11:58, Carsten Schoenert <c.schoenert@xxxxxxxxxxx> wrote:
>> 
>> Hi,
>> 
>> Am 30.12.2017 um 00:45 schrieb Nick Østergaard:
>>> We could have a fork of wx in the kicad org with a branch where we
>>> rebase the patches to. Then it is easy to fetch for others. The osx devs
>>> could maintain this. But having it in the kicad org gives more
>>> visibility and we don't need to habe them directly in the kicad source.
>> 
>> in a longterm it's never a good idea to maintain such patches as this
>> always costs time and energy, has some someone tried to upstream these
>> patches? That what I normally would do.
>> 
>> -- 
>> Regards
>> Carsten Schoenert
>> 
>> _______________________________________________
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp
> 
> 
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp



Follow ups

References