kicad-developers team mailing list archive

[Wayne Stambaugh <stambaughw@xxxxxxxxx>]

John,

I took a look at your patch.  Is there any reason why you didn't use
wxMessageDialog instead of creating wxFormbuilder project for such a
simple dialog?  It seems to me that wxMessageDialog would do the trick
as it allows you to change the strings for the Ok and Cancel buttons.
Other than that, everything else seems fine.

Cheers,

Wayne

On 12/31/2017 4:28 PM, Jon Evans wrote:
> For your consideration, a patch is attached that implements the above.
> 
> 
> On Sun, Dec 31, 2017 at 2:24 PM, Jon Evans <jon@xxxxxxxxxxxxx
> <mailto:jon@xxxxxxxxxxxxx>> wrote:
> 
>     I think that getting automatic OpenGL detection and recovery working
>     for 5.0 might be ambitious.
>     Maybe Chris can detail what the next steps are for his approach
>     there, but in case we want to push that to a later release, here's
>     what I propose:
> 
>     1) Rename the View menu options based on my proposal "Legacy",
>     "Modern (Accelerated)", "Modern (Fallback)"
>     2) Change PCB_BASE_FRAME::SwitchCanvas to save the canvas config
>     value after calling UseGalCanvas() rather than before.
>     3) Show a first-run dialog like the mockup in my earlier email, IF
>     canvas is not OpenGL and the dialog has not been shown before
>     44) If user clicks "yes" in the first run dialog, then:
>         (a) set the config value to prevent the dialog from showing again,
>         (b) Set the canvas config setting to Cairo (but don't switch the
>     GAL to Cairo), then
>         (c) switch to OpenGL canvas using SwitchCanvas()
> 
>     That way, if the app crashes in step 4c, it should come back up as
>     Cairo on the next launch (assuming we crash right away when trying
>     to set up the canvas)
> 
>     Any concerns with the above?
> 
>     -Jon
> 
> 
> 
>     On Sun, Dec 31, 2017 at 1:55 PM, Jeff Young <jeff@xxxxxxxxx
>     <mailto:jeff@xxxxxxxxx>> wrote:
> 
>         +1
> 
>         No menu items.  Just a checkbox for Enable Hardware Acceleration
>         in Preferences.
> 
>>         On 31 Dec 2017, at 18:36, Andy Peters <devel@xxxxxxxxx
>>         <mailto:devel@xxxxxxxxx>> wrote:
>>
>>>         - In the case of graphics glitches, inform the users in the
>>>         FAQ/Manual
>>>         that they can fall back to software renderer in the View menu.
>>>         - Don't use the term 'canvas' or 'view'. Just 'Enable HW
>>>         acceleration’.
>>
>>         I like that. The fewer technical/programmer terms, the better.
> 
> 
>         _______________________________________________
>         Mailing list: https://launchpad.net/~kicad-developers
>         <https://launchpad.net/~kicad-developers>
>         Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>         <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
>         Unsubscribe : https://launchpad.net/~kicad-developers
>         <https://launchpad.net/~kicad-developers>
>         More help   : https://help.launchpad.net/ListHelp
>         <https://help.launchpad.net/ListHelp>
> 
> 
> 
> 
> 
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>