← Back to team overview

kicad-developers team mailing list archive

Re: [PATCH] eeschema: make footprint preview optional

 

Not sure what you mean by "this"; if you mean the improved layout in
this patch then tonight or tomorrow night, and if you mean the whole
performance issues in general I can't even guess.

Can you point me to the LIB_ID bug? That's probably a relatively easy
fix that I can handle tonight or tomorrow as well.

On Wed, Jan 03, 2018 at 03:44:49PM -0500, Wayne Stambaugh wrote:
> How soon do you think it will take you got get around to fixing this?
> There is a bug in the symbol chooser that always returns the root symbol
> LIB_ID rather the alias LIB_ID that needs to be addressed.  I would
> rather avoided merge conflicts if I can help it.  I'm busy trying to
> keep up with the current patch volume so anything to prevent extra work
> is a good thing.
> 
> On 1/3/2018 3:37 PM, Chris Pavlina wrote:
> > There's some performance issue that's not just github, but related to
> > the footprint parse stage I _couldn't_ background due to LOCALE_IO
> > issues, which seems to run really slow on some people's systems. Some
> > subtle caching bug may be involved too. Eventually I'd like to untangle
> > all the LOCALE_IO stuff so parsing can be totally backgrounded but my
> > day job takes up way too much for me to get that done in a timely manner
> > currently.
> > 
> > I may improve this slightly before pushing - with the footprint section
> > simply removed, the layout of the dialog is a bit suboptimal, with the
> > symbol preview taking up valuable space that the info box could use. I
> > might have it populate the dialog with something more close to the
> > original layout when footprints are disabled.
> > 
> > On Wed, Jan 03, 2018 at 02:11:45PM -0500, Wayne Stambaugh wrote:
> >> Chris,
> >>
> >> I'm OK with this patch so go ahead and push it when you get a chance.  I
> >> wonder if the majority of the performance issues are due to loading
> >> footprints using the github plugin.  I'm guessing if the footprints were
> >> on the user's local drive that the lag caused by loading all of the
> >> footprint libraries would be all that objectionable.  For version 5, the
> >> default global footprint table will point to the footprint libraries
> >> that get installed locally instead of the github libraries which are no
> >> longer being maintained.  Thanks for addressing this issue.
> >>
> >> Cheers,
> >>
> >> Wayne
> >>
> >> On 1/2/2018 9:55 PM, Chris Pavlina wrote:
> >>> Hi,
> >>>
> >>> I've attached a patch to make the footprint preview and selection
> >>> functionality in eeschema optional, to address primarily performance
> >>> concerns some users have, and also to address the handful of planned
> >>> features still unimplemented. It's a runtime option, default OFF, so
> >>> users can easily enable it if they like. I should have time after the
> >>> release to work more on polishing it and then we can take the option
> >>> back out.
> >>>
> >>>
> >>>
> >>> _______________________________________________
> >>> Mailing list: https://launchpad.net/~kicad-developers
> >>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> >>> Unsubscribe : https://launchpad.net/~kicad-developers
> >>> More help   : https://help.launchpad.net/ListHelp
> >>>
> >>
> >> _______________________________________________
> >> Mailing list: https://launchpad.net/~kicad-developers
> >> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> >> Unsubscribe : https://launchpad.net/~kicad-developers
> >> More help   : https://help.launchpad.net/ListHelp


Follow ups

References