kicad-developers team mailing list archive
-
kicad-developers team
-
Mailing list archive
-
Message #32825
Re: Default Canvas for v5
It compiles now but I found an issue. If the user runs pcbnew with the
OpenGL canvas selected, switches to the legacy canvas, and closes
pcbnew, the dialog will show up the next time they launch pcbnew. If
the user is already using the OpenGL canvas, then showing the dialog
after the user switches to the legacy canvas doesn't make sense. I'm
guessing if the user switched to the opengl canvas to the legacy canvas.
that the user understands why they would want to do that so the dialog
is unnecessary.
On 01/04/2018 08:42 AM, Jon Evans wrote:
> Sorry about that, attached the wrong patch file.
>
> On Thu, Jan 4, 2018 at 8:39 AM, Wayne Stambaugh <stambaughw@xxxxxxxxx
> <mailto:stambaughw@xxxxxxxxx>> wrote:
>
> Hey Jon,
>
> Did you forget to add a file to this patch? I'm getting the following
> build error:
>
> CMakeFiles/gerbview_kiface.dir/gerbview_frame.cpp.o: In function
> `GERBVIEW_FRAME::GERBVIEW_FRAME(KIWAY*, wxWindow*)':
> /home/wayne/src/kicad/kicad-trunk/gerbview/gerbview_frame.cpp:218:
> undefined reference to
> `EDA_DRAW_FRAME::ShowFirstRunDialog(EDA_DRAW_FRAME*)'
>
> I don't see a ShowFirstRunDialog() in the patch.
>
> Wayne
>
>
> On 01/03/2018 10:27 PM, Jon Evans wrote:
> > Hi Wayne, Nick,
> >
> > Updated patch attached with your suggestions.
> >
> > -Jon
> >
> > On Wed, Jan 3, 2018 at 3:36 PM, Nick Østergaard <oe.nick@xxxxxxxxx <mailto:oe.nick@xxxxxxxxx>
> > <mailto:oe.nick@xxxxxxxxx <mailto:oe.nick@xxxxxxxxx>>> wrote:
> >
> > Hmm, maybe it is ok to use the technical terms OpenGL and Cairo in
> > the help text for the menu item. Afterall those terms have been used
> > a lot in help forums and launchpad, so it may make it easier for the
> > curious to discover.
> >
> > 2018-01-03 21:15 GMT+01:00 Wayne Stambaugh <stambaughw@xxxxxxxxx <mailto:stambaughw@xxxxxxxxx>
> > <mailto:stambaughw@xxxxxxxxx <mailto:stambaughw@xxxxxxxxx>>>:
> >
> > There is also wxRichMessageDialog[1] which has an optional
> > checkbox for
> > show once features.
> >
> > [1]:
> > http://docs.wxwidgets.org/3.0/classwx_rich_message_dialog.html
> <http://docs.wxwidgets.org/3.0/classwx_rich_message_dialog.html>
> > <http://docs.wxwidgets.org/3.0/classwx_rich_message_dialog.html
> <http://docs.wxwidgets.org/3.0/classwx_rich_message_dialog.html>>
> >
> > On 1/3/2018 3:13 PM, Jon Evans wrote:
> > > I figured we might want to re-use this in the future if we ever have
> > > additional "show once" things that are more complicated than yes/no
> > > (although I didn't make it with formbuilder).
> > > It would be fine to switch to a messagedialog. I can probably do that
> > > tonight.
> > >
> > > -Jon
> > >
> > > On Wed, Jan 3, 2018 at 3:09 PM, Wayne Stambaugh <stambaughw@xxxxxxxxx <mailto:stambaughw@xxxxxxxxx>
> <mailto:stambaughw@xxxxxxxxx <mailto:stambaughw@xxxxxxxxx>>
> > > <mailto:stambaughw@xxxxxxxxx
> <mailto:stambaughw@xxxxxxxxx> <mailto:stambaughw@xxxxxxxxx
> <mailto:stambaughw@xxxxxxxxx>>>> wrote:
> > >
> > > John,
> > >
> > > I took a look at your patch. Is there any reason
> why you didn't use
> > > wxMessageDialog instead of creating wxFormbuilder
> project for such a
> > > simple dialog? It seems to me that wxMessageDialog
> would do the trick
> > > as it allows you to change the strings for the Ok
> and Cancel buttons.
> > > Other than that, everything else seems fine.
> > >
> > > Cheers,
> > >
> > > Wayne
> > >
> > > On 12/31/2017 4:28 PM, Jon Evans wrote:
> > > > For your consideration, a patch is attached that
> implements the above.
> > > >
> > > >
> > > > On Sun, Dec 31, 2017 at 2:24 PM, Jon Evans
> <jon@xxxxxxxxxxxxx <mailto:jon@xxxxxxxxxxxxx>
> <mailto:jon@xxxxxxxxxxxxx <mailto:jon@xxxxxxxxxxxxx>>
> > <mailto:jon@xxxxxxxxxxxxx <mailto:jon@xxxxxxxxxxxxx>
> <mailto:jon@xxxxxxxxxxxxx <mailto:jon@xxxxxxxxxxxxx>>>
> > > > <mailto:jon@xxxxxxxxxxxxx
> <mailto:jon@xxxxxxxxxxxxx> <mailto:jon@xxxxxxxxxxxxx
> <mailto:jon@xxxxxxxxxxxxx>>
> > <mailto:jon@xxxxxxxxxxxxx <mailto:jon@xxxxxxxxxxxxx>
> <mailto:jon@xxxxxxxxxxxxx <mailto:jon@xxxxxxxxxxxxx>>>>> wrote:
> > > >
> > > > I think that getting automatic OpenGL
> detection and recovery working
> > > > for 5.0 might be ambitious.
> > > > Maybe Chris can detail what the next steps are
> for his approach
> > > > there, but in case we want to push that to a
> later release, here's
> > > > what I propose:
> > > >
> > > > 1) Rename the View menu options based on my
> proposal "Legacy",
> > > > "Modern (Accelerated)", "Modern (Fallback)"
> > > > 2) Change PCB_BASE_FRAME::SwitchCanvas to save
> the canvas config
> > > > value after calling UseGalCanvas() rather than
> before.
> > > > 3) Show a first-run dialog like the mockup in
> my earlier email, IF
> > > > canvas is not OpenGL and the dialog has not
> been shown before
> > > > 44) If user clicks "yes" in the first run
> dialog, then:
> > > > (a) set the config value to prevent the
> dialog from showing again,
> > > > (b) Set the canvas config setting to Cairo
> (but don't switch the
> > > > GAL to Cairo), then
> > > > (c) switch to OpenGL canvas using
> SwitchCanvas()
> > > >
> > > > That way, if the app crashes in step 4c, it
> should come back up as
> > > > Cairo on the next launch (assuming we crash
> right away when trying
> > > > to set up the canvas)
> > > >
> > > > Any concerns with the above?
> > > >
> > > > -Jon
> > > >
> > > >
> > > >
> > > > On Sun, Dec 31, 2017 at 1:55 PM, Jeff Young
> <jeff@xxxxxxxxx <mailto:jeff@xxxxxxxxx> <mailto:jeff@xxxxxxxxx
> <mailto:jeff@xxxxxxxxx>> <mailto:jeff@xxxxxxxxx <mailto:jeff@xxxxxxxxx>
> > <mailto:jeff@xxxxxxxxx <mailto:jeff@xxxxxxxxx>>>
> > > > <mailto:jeff@xxxxxxxxx <mailto:jeff@xxxxxxxxx>
> <mailto:jeff@xxxxxxxxx <mailto:jeff@xxxxxxxxx>>
> <mailto:jeff@xxxxxxxxx <mailto:jeff@xxxxxxxxx>
> > <mailto:jeff@xxxxxxxxx <mailto:jeff@xxxxxxxxx>>>>> wrote:
> > > >
> > > > +1
> > > >
> > > > No menu items. Just a checkbox for Enable
> Hardware Acceleration
> > > > in Preferences.
> > > >
> > > >> On 31 Dec 2017, at 18:36, Andy Peters
> <devel@xxxxxxxxx <mailto:devel@xxxxxxxxx> <mailto:devel@xxxxxxxxx
> <mailto:devel@xxxxxxxxx>> <mailto:devel@xxxxxxxxx
> <mailto:devel@xxxxxxxxx>
> > <mailto:devel@xxxxxxxxx <mailto:devel@xxxxxxxxx>>>
> > > >> <mailto:devel@xxxxxxxxx
> <mailto:devel@xxxxxxxxx> <mailto:devel@xxxxxxxxx
> <mailto:devel@xxxxxxxxx>> <mailto:devel@xxxxxxxxx
> <mailto:devel@xxxxxxxxx>
> > <mailto:devel@xxxxxxxxx <mailto:devel@xxxxxxxxx>>>>> wrote:
> > > >>
> > > >>> - In the case of graphics glitches,
> inform the users in the
> > > >>> FAQ/Manual
> > > >>> that they can fall back to software
> renderer in the View menu.
> > > >>> - Don't use the term 'canvas' or 'view'.
> Just 'Enable HW
> > > >>> acceleration’.
> > > >>
> > > >> I like that. The fewer
> technical/programmer terms, the better.
> > > >
> > > >
> > > >
> _______________________________________________
> > > > Mailing list:
> https://launchpad.net/~kicad-developers
> <https://launchpad.net/~kicad-developers>
> > <https://launchpad.net/~kicad-developers
> <https://launchpad.net/~kicad-developers>>
> > > <https://launchpad.net/~kicad-developers
> <https://launchpad.net/~kicad-developers>
> > <https://launchpad.net/~kicad-developers
> <https://launchpad.net/~kicad-developers>>>
> > > > <https://launchpad.net/~kicad-developers
> <https://launchpad.net/~kicad-developers>
> > <https://launchpad.net/~kicad-developers
> <https://launchpad.net/~kicad-developers>>
> > > <https://launchpad.net/~kicad-developers
> <https://launchpad.net/~kicad-developers>
> > <https://launchpad.net/~kicad-developers
> <https://launchpad.net/~kicad-developers>>>>
> > > > Post to :
> kicad-developers@xxxxxxxxxxxxxxxxxxx
> <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
> > <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx
> <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>>
> > > <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx
> <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
> > <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx
> <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>>>
> > > >
> <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx
> <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
> > <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx
> <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>>
> > > <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx
> <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
> > <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx
> <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>>>>
> > > > Unsubscribe :
> > https://launchpad.net/~kicad-developers
> <https://launchpad.net/~kicad-developers>
> > <https://launchpad.net/~kicad-developers
> <https://launchpad.net/~kicad-developers>>
> > > <https://launchpad.net/~kicad-developers
> <https://launchpad.net/~kicad-developers>
> > <https://launchpad.net/~kicad-developers
> <https://launchpad.net/~kicad-developers>>>
> > > > <https://launchpad.net/~kicad-developers
> <https://launchpad.net/~kicad-developers>
> > <https://launchpad.net/~kicad-developers
> <https://launchpad.net/~kicad-developers>>
> > > <https://launchpad.net/~kicad-developers
> <https://launchpad.net/~kicad-developers>
> > <https://launchpad.net/~kicad-developers
> <https://launchpad.net/~kicad-developers>>>>
> > > > More help :
> > https://help.launchpad.net/ListHelp
> <https://help.launchpad.net/ListHelp>
> > <https://help.launchpad.net/ListHelp
> <https://help.launchpad.net/ListHelp>>
> > > <https://help.launchpad.net/ListHelp
> <https://help.launchpad.net/ListHelp>
> > <https://help.launchpad.net/ListHelp
> <https://help.launchpad.net/ListHelp>>>
> > > > <https://help.launchpad.net/ListHelp
> <https://help.launchpad.net/ListHelp>
> > <https://help.launchpad.net/ListHelp
> <https://help.launchpad.net/ListHelp>>
> > > <https://help.launchpad.net/ListHelp
> <https://help.launchpad.net/ListHelp>
> > <https://help.launchpad.net/ListHelp
> <https://help.launchpad.net/ListHelp>>>>
> > > >
> > > >
> > > >
> > > >
> > > >
> > > > _______________________________________________
> > > > Mailing list:
> https://launchpad.net/~kicad-developers
> <https://launchpad.net/~kicad-developers>
> > <https://launchpad.net/~kicad-developers
> <https://launchpad.net/~kicad-developers>>
> > > <https://launchpad.net/~kicad-developers
> <https://launchpad.net/~kicad-developers>
> > <https://launchpad.net/~kicad-developers
> <https://launchpad.net/~kicad-developers>>>
> > > > Post to : kicad-developers@xxxxxxxxxxxxxxxxxxx
> <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
> > <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx
> <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>>
> > > <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx
> <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
> > <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx
> <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>>>
> > > > Unsubscribe :
> https://launchpad.net/~kicad-developers
> <https://launchpad.net/~kicad-developers>
> > <https://launchpad.net/~kicad-developers
> <https://launchpad.net/~kicad-developers>>
> > > <https://launchpad.net/~kicad-developers
> <https://launchpad.net/~kicad-developers>
> > <https://launchpad.net/~kicad-developers
> <https://launchpad.net/~kicad-developers>>>
> > > > More help : https://help.launchpad.net/ListHelp
> <https://help.launchpad.net/ListHelp>
> > <https://help.launchpad.net/ListHelp
> <https://help.launchpad.net/ListHelp>>
> > > <https://help.launchpad.net/ListHelp
> <https://help.launchpad.net/ListHelp>
> > <https://help.launchpad.net/ListHelp
> <https://help.launchpad.net/ListHelp>>>
> > > >
> > >
> > > _______________________________________________
> > > Mailing list:
> https://launchpad.net/~kicad-developers
> <https://launchpad.net/~kicad-developers>
> > <https://launchpad.net/~kicad-developers
> <https://launchpad.net/~kicad-developers>>
> > > <https://launchpad.net/~kicad-developers
> <https://launchpad.net/~kicad-developers>
> > <https://launchpad.net/~kicad-developers
> <https://launchpad.net/~kicad-developers>>>
> > > Post to : kicad-developers@xxxxxxxxxxxxxxxxxxx
> <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
> > <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx
> <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>>
> > > <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx
> <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
> > <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx
> <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>>>
> > > Unsubscribe :
> https://launchpad.net/~kicad-developers
> <https://launchpad.net/~kicad-developers>
> > <https://launchpad.net/~kicad-developers
> <https://launchpad.net/~kicad-developers>>
> > > <https://launchpad.net/~kicad-developers
> <https://launchpad.net/~kicad-developers>
> > <https://launchpad.net/~kicad-developers
> <https://launchpad.net/~kicad-developers>>>
> > > More help : https://help.launchpad.net/ListHelp
> <https://help.launchpad.net/ListHelp>
> > <https://help.launchpad.net/ListHelp
> <https://help.launchpad.net/ListHelp>>
> > > <https://help.launchpad.net/ListHelp
> <https://help.launchpad.net/ListHelp>
> > <https://help.launchpad.net/ListHelp
> <https://help.launchpad.net/ListHelp>>>
> > >
> > >
> >
> > _______________________________________________
> > Mailing list: https://launchpad.net/~kicad-developers
> <https://launchpad.net/~kicad-developers>
> > <https://launchpad.net/~kicad-developers
> <https://launchpad.net/~kicad-developers>>
> > Post to : kicad-developers@xxxxxxxxxxxxxxxxxxx
> <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
> > <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx
> <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>>
> > Unsubscribe : https://launchpad.net/~kicad-developers
> <https://launchpad.net/~kicad-developers>
> > <https://launchpad.net/~kicad-developers
> <https://launchpad.net/~kicad-developers>>
> > More help : https://help.launchpad.net/ListHelp
> <https://help.launchpad.net/ListHelp>
> > <https://help.launchpad.net/ListHelp
> <https://help.launchpad.net/ListHelp>>
> >
> >
> >
>
>
Follow ups
References
-
Default Canvas for v5
From: José Ignacio, 2017-12-30
-
Re: Default Canvas for v5
From: Jon Evans, 2017-12-31
-
Re: Default Canvas for v5
From: Wayne Stambaugh, 2017-12-31
-
Re: Default Canvas for v5
From: Nick Østergaard, 2017-12-31
-
Re: Default Canvas for v5
From: Tomasz Wlostowski, 2017-12-31
-
Re: Default Canvas for v5
From: Andy Peters, 2017-12-31
-
Re: Default Canvas for v5
From: Jeff Young, 2017-12-31
-
Re: Default Canvas for v5
From: Jon Evans, 2017-12-31
-
Re: Default Canvas for v5
From: Jon Evans, 2017-12-31
-
Re: Default Canvas for v5
From: Wayne Stambaugh, 2018-01-03
-
Re: Default Canvas for v5
From: Jon Evans, 2018-01-03
-
Re: Default Canvas for v5
From: Wayne Stambaugh, 2018-01-03
-
Re: Default Canvas for v5
From: Nick Østergaard, 2018-01-03
-
Re: Default Canvas for v5
From: Jon Evans, 2018-01-04
-
Re: Default Canvas for v5
From: Wayne Stambaugh, 2018-01-04
-
Re: Default Canvas for v5
From: Jon Evans, 2018-01-04
