kicad-developers team mailing list archive
-
kicad-developers team
-
Mailing list archive
-
Message #32842
Re: [PATCH] automatically add extension to sim workbook files
Dan,
Please make this case insensitive. Otherwise on case sensitive
platforms where someone has decided to use .Wbk, .WBK, etc. for the file
extension, your code doesn't add .wbk.
Thanks,
Wayne
On 01/04/2018 02:37 PM, Dan Weatherill wrote:
> Hi,
> at present, the simulator dialog saves workbook files without checking
> extensions, but only opens workbook files that have the .wbk extension. This
> makes it very easy to save files and not be able to open them (without some
> minor frustration). The attached patch checks the extension in the save file
> dialog and adds it if not present.
>
> This is intended as a very gentle attempt to start contributing to kicad, and
> seeing if I have the patch format / commit messages etc correct.
>
> Many thanks,
> Dan W
>
>
>
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help : https://help.launchpad.net/ListHelp
>
Follow ups
References