← Back to team overview

kicad-developers team mailing list archive

Re: [PATCH] Add bidirectional net highlight cross-probing

 

I was just expecting the net to be highlighted when i filed the report, I have a memory of being able to do this on a previous nightly, nothing else.

But after the comments, maybe I remember wrong? Jumping around in the schematic when highlighting net is not something I want at least. I rather just have it highlighted and manually move around. Actually I would prefer if the pcbnew highlight didnt even zoom, I would like to just see if a line of this net is crossing where I am currently zoom, otherwise I can manually zoom to fit the pcb to the highlight.

my 2 cents, thanks for creating a patch for this though!

- Kristoffer


On 2018-01-07 15:50, Jon Evans wrote:
Now we are really straying into new-feature land...  as far as I can tell, there is no code in eeschema for "locate and zoom to fit a net". I could pick some random object on the net and locate that without much code, but is that the behavior we want? (especially for nets that exist on multiple sheets)

-Jon

On Sun, Jan 7, 2018 at 9:02 AM, Nick Østergaard <oe.nick@xxxxxxxxx <mailto:oe.nick@xxxxxxxxx>> wrote:

    Hi Jon,

    I just tested this woth both patches applied. It seems that
    selecting nets in eeschema the zoom to view works good in pcbnew,
    but the other way around not so well. It does not always zoom to
    the net in eeschema when selecing nets in pcbnew.

    2018-01-07 3:30 GMT+01:00 Jon Evans <jon@xxxxxxxxxxxxx
    <mailto:jon@xxxxxxxxxxxxx>>:

        Hi Wayne,

        Give this patch a try on top of my first one and see if it
        does what you want.

        -Jon

        On Sat, Jan 6, 2018 at 8:58 PM, Chris Pavlina
        <pavlina.chris@xxxxxxxxx <mailto:pavlina.chris@xxxxxxxxx>> wrote:

            On Sun, Jan 07, 2018 at 01:48:34AM +0000, Jon Evans wrote:
            > Do I get a pass if I did this because I was browsing the
            bug list looking
            > for more things to fix? ;-)

            I suppose so, I disagree with it having been classified as
            a bug but
            that's not your fault ;)

            >
            > Wayne, I'll work on the recentering in PcbNew, it
            shouldn't be too much to
            > add.
            >
            > On Sat, Jan 6, 2018 at 7:45 PM, Chris Pavlina
            <pavlina.chris@xxxxxxxxx <mailto:pavlina.chris@xxxxxxxxx>>
            > wrote:
            >
            > > I like it too, I just worry that by accepting even
            small features during
            > > freeze we're encouraging people to do things that
            aren't bugfixes and
            > > release cleanup...
            > >
            > > On Sun, Jan 07, 2018 at 12:35:58AM +0000, Wayne
            Stambaugh wrote:
            > > > Jon,
            > > >
            > > > I just tested this and I like it!  It doesn't seem
            like a high risk
            > > > feature so if now one objects I'm going to merge
            it.  If you have time,
            > > > I do have one minor request.  When highlighting a
            net in the board
            > > > editor, if the net in the schematic editor is
            scrolled of the display,
            > > > the schematic editor centers the net so you can see
            it. The same thing
            > > > does not happen when a net is highlighted in the
            schematic editor and
            > > > the net on the board is scrolled off the display. 
            Would you please fix
            > > > this so the net in the board editor is centered on
            the display when the
            > > > net in the schematic editor is selected.
            > > >
            > > > Thanks,
            > > >
            > > > Wayne
            > > >
            > > > On 01/06/2018 03:52 PM, Jon Evans wrote:
            > > > > I implemented this in response to a bug report:
            > > > > https://bugs.launchpad.net/kicad/+bug/1738875
            <https://bugs.launchpad.net/kicad/+bug/1738875>
            > > > >
            > > > > But it is kind of on a blurred line between bug
            fix and new feature.
            > > > > I'll leave it up to Wayne et. al. to decide on if
            to merge this for V5.
            > > > >
            > > > > Basically, beforehand, cross-probing highlighted
            nets only if you
            > > > > clicked on a component pad.
            > > > > Now there is a separate cross-probing message for
            a net name, so that
            > > if
            > > > > the highlight tool is selected in both eeschema
            and pcbnew, selecting
            > > > > any part of a net will cross-probe.
            > > > >
            > > > > -Jon
            > > > >
            > > > >
            > > > > _______________________________________________
            > > > > Mailing list:
            https://launchpad.net/~kicad-developers
            <https://launchpad.net/%7Ekicad-developers>
            > > > > Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
            <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
            > > > > Unsubscribe :
            https://launchpad.net/~kicad-developers
            <https://launchpad.net/%7Ekicad-developers>
            > > > > More help   : https://help.launchpad.net/ListHelp
            <https://help.launchpad.net/ListHelp>
            > > > >
            > > >
            > > > _______________________________________________
            > > > Mailing list:
            https://launchpad.net/~kicad-developers
            <https://launchpad.net/%7Ekicad-developers>
            > > > Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
            <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
            > > > Unsubscribe :
            https://launchpad.net/~kicad-developers
            <https://launchpad.net/%7Ekicad-developers>
            > > > More help   : https://help.launchpad.net/ListHelp
            <https://help.launchpad.net/ListHelp>
            > >
            > > _______________________________________________
            > > Mailing list: https://launchpad.net/~kicad-developers
            <https://launchpad.net/%7Ekicad-developers>
            > > Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
            <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
            > > Unsubscribe : https://launchpad.net/~kicad-developers
            <https://launchpad.net/%7Ekicad-developers>
            > > More help   : https://help.launchpad.net/ListHelp
            <https://help.launchpad.net/ListHelp>
            > >



        _______________________________________________
        Mailing list: https://launchpad.net/~kicad-developers
        <https://launchpad.net/%7Ekicad-developers>
        Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
        <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
        Unsubscribe : https://launchpad.net/~kicad-developers
        <https://launchpad.net/%7Ekicad-developers>
        More help   : https://help.launchpad.net/ListHelp
        <https://help.launchpad.net/ListHelp>





_______________________________________________
Mailing list: https://launchpad.net/~kicad-developers
Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp


References