← Back to team overview

kicad-developers team mailing list archive

Re: [PATCH] Allow selecting footprints that are only silkscreen using silk layers

 

Hi Wayne,

I think you forgot to push the patch. I can not see it on master.

2018-01-06 23:29 GMT+01:00 Wayne Stambaugh <stambaughw@xxxxxxxxx>:

> I misunderstood the purpose of this patch as well.  I tested it and it
> works as advertised so I merged it.  Thank you for your contribution.
>
> Cheers,
>
> Wayne
>
> On 01/06/2018 03:30 PM, Jon Evans wrote:
> > The Launchpad bug description has a pretty good example -- if you place
> > the KiCad logo (from the library) on a silk layer, you can't interact
> > with it when using high-contrast on the silk layer without this patch.
> > But if you place it next to another component that has non-silk data
> > (i.e. pads, etc) you can't select or move that component from the silk
> > layer.
> >
> > On Sat, Jan 6, 2018 at 3:28 PM, Chris Pavlina <pavlina.chris@xxxxxxxxx
> > <mailto:pavlina.chris@xxxxxxxxx>> wrote:
> >
> >     Wait, I may have misunderstood what this patch does. Disregard - I'd
> >     test it myself but my source tree is a bit of a mess at the moment...
> >
> >     On Sat, Jan 06, 2018 at 08:17:11PM +0000, Jon Evans wrote:
> >     > The intent was to only allow selection of "components" which only
> >     exist on
> >     > the silkscreen layer.  It makes sense to me to be able to move
> >     these around
> >     > when high-contrasting on the silkscreen layer, since they are
> >     basically
> >     > just "free silkscreen" objects.
> >     >
> >     > On Sat, Jan 6, 2018 at 3:15 PM, Chris Pavlina
> >     <pavlina.chris@xxxxxxxxx <mailto:pavlina.chris@xxxxxxxxx>>
> >     > wrote:
> >     >
> >     > > Yeah, this goes against the whole reason I use high contrast
> mode.
> >     > >
> >     > > On Sat, Jan 06, 2018 at 08:11:00PM +0000, Wayne Stambaugh wrote:
> >     > > > Is this behavior desirable?  I know some users who use the
> >     high contrast
> >     > > > mode to prevent the disambiguation menus when editing high
> density
> >     > > > boards.  Wouldn't this patch make that issue worse since now
> >     you are
> >     > > > including the silkscreen layers which will increase the
> >     probability of a
> >     > > > disambiguation?  I would like to get more feedback on this
> >     before I
> >     > > > merge this patch.
> >     > > >
> >     > > > On 01/04/2018 05:40 PM, Jon Evans wrote:
> >     > > > > See: https://bugs.launchpad.net/kicad/+bug/1741350
> >     <https://bugs.launchpad.net/kicad/+bug/1741350>
> >     > > > >
> >     > > > >
> >     > > > > _______________________________________________
> >     > > > > Mailing list: https://launchpad.net/~kicad-developers
> >     <https://launchpad.net/~kicad-developers>
> >     > > > > Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> >     <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
> >     > > > > Unsubscribe : https://launchpad.net/~kicad-developers
> >     <https://launchpad.net/~kicad-developers>
> >     > > > > More help   : https://help.launchpad.net/ListHelp
> >     <https://help.launchpad.net/ListHelp>
> >     > > > >
> >     > > >
> >     > > > _______________________________________________
> >     > > > Mailing list: https://launchpad.net/~kicad-developers
> >     <https://launchpad.net/~kicad-developers>
> >     > > > Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> >     <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
> >     > > > Unsubscribe : https://launchpad.net/~kicad-developers
> >     <https://launchpad.net/~kicad-developers>
> >     > > > More help   : https://help.launchpad.net/ListHelp
> >     <https://help.launchpad.net/ListHelp>
> >     > >
> >     > > _______________________________________________
> >     > > Mailing list: https://launchpad.net/~kicad-developers
> >     <https://launchpad.net/~kicad-developers>
> >     > > Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> >     <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
> >     > > Unsubscribe : https://launchpad.net/~kicad-developers
> >     <https://launchpad.net/~kicad-developers>
> >     > > More help   : https://help.launchpad.net/ListHelp
> >     <https://help.launchpad.net/ListHelp>
> >     > >
> >
> >
>
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>

Follow ups

References