← Back to team overview

kicad-developers team mailing list archive

Re: [PATCH] Add bidirectional net highlight cross-probing

 

Jon,

Fantastic!  This is what I was looking for.  The patch doesn't seem that
invasive so I merged it.  Since this only works in the gal canvases, I'm
sure someone will file a but report about it not working in the legacy
canvas but I would rather not spend time on that since the legacy canvas
will eventually go away.

Thanks,

Wayne

On 01/06/2018 09:30 PM, Jon Evans wrote:
> Hi Wayne,
> 
> Give this patch a try on top of my first one and see if it does what you
> want.
> 
> -Jon
> 
> On Sat, Jan 6, 2018 at 8:58 PM, Chris Pavlina <pavlina.chris@xxxxxxxxx
> <mailto:pavlina.chris@xxxxxxxxx>> wrote:
> 
>     On Sun, Jan 07, 2018 at 01:48:34AM +0000, Jon Evans wrote:
>     > Do I get a pass if I did this because I was browsing the bug list looking
>     > for more things to fix? ;-)
> 
>     I suppose so, I disagree with it having been classified as a bug but
>     that's not your fault ;)
> 
>     >
>     > Wayne, I'll work on the recentering in PcbNew, it shouldn't be too
>     much to
>     > add.
>     >
>     > On Sat, Jan 6, 2018 at 7:45 PM, Chris Pavlina
>     <pavlina.chris@xxxxxxxxx <mailto:pavlina.chris@xxxxxxxxx>>
>     > wrote:
>     >
>     > > I like it too, I just worry that by accepting even small
>     features during
>     > > freeze we're encouraging people to do things that aren't
>     bugfixes and
>     > > release cleanup...
>     > >
>     > > On Sun, Jan 07, 2018 at 12:35:58AM +0000, Wayne Stambaugh wrote:
>     > > > Jon,
>     > > >
>     > > > I just tested this and I like it!  It doesn't seem like a high
>     risk
>     > > > feature so if now one objects I'm going to merge it.  If you
>     have time,
>     > > > I do have one minor request.  When highlighting a net in the board
>     > > > editor, if the net in the schematic editor is scrolled of the
>     display,
>     > > > the schematic editor centers the net so you can see it.  The
>     same thing
>     > > > does not happen when a net is highlighted in the schematic
>     editor and
>     > > > the net on the board is scrolled off the display.  Would you
>     please fix
>     > > > this so the net in the board editor is centered on the display
>     when the
>     > > > net in the schematic editor is selected.
>     > > >
>     > > > Thanks,
>     > > >
>     > > > Wayne
>     > > >
>     > > > On 01/06/2018 03:52 PM, Jon Evans wrote:
>     > > > > I implemented this in response to a bug report:
>     > > > > https://bugs.launchpad.net/kicad/+bug/1738875
>     <https://bugs.launchpad.net/kicad/+bug/1738875>
>     > > > >
>     > > > > But it is kind of on a blurred line between bug fix and new
>     feature.
>     > > > > I'll leave it up to Wayne et. al. to decide on if to merge
>     this for V5.
>     > > > >
>     > > > > Basically, beforehand, cross-probing highlighted nets only
>     if you
>     > > > > clicked on a component pad.
>     > > > > Now there is a separate cross-probing message for a net
>     name, so that
>     > > if
>     > > > > the highlight tool is selected in both eeschema and pcbnew,
>     selecting
>     > > > > any part of a net will cross-probe.
>     > > > >
>     > > > > -Jon
>     > > > >
>     > > > >
>     > > > > _______________________________________________
>     > > > > Mailing list: https://launchpad.net/~kicad-developers
>     <https://launchpad.net/~kicad-developers>
>     > > > > Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>     <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
>     > > > > Unsubscribe : https://launchpad.net/~kicad-developers
>     <https://launchpad.net/~kicad-developers>
>     > > > > More help   : https://help.launchpad.net/ListHelp
>     <https://help.launchpad.net/ListHelp>
>     > > > >
>     > > >
>     > > > _______________________________________________
>     > > > Mailing list: https://launchpad.net/~kicad-developers
>     <https://launchpad.net/~kicad-developers>
>     > > > Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>     <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
>     > > > Unsubscribe : https://launchpad.net/~kicad-developers
>     <https://launchpad.net/~kicad-developers>
>     > > > More help   : https://help.launchpad.net/ListHelp
>     <https://help.launchpad.net/ListHelp>
>     > >
>     > > _______________________________________________
>     > > Mailing list: https://launchpad.net/~kicad-developers
>     <https://launchpad.net/~kicad-developers>
>     > > Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>     <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
>     > > Unsubscribe : https://launchpad.net/~kicad-developers
>     <https://launchpad.net/~kicad-developers>
>     > > More help   : https://help.launchpad.net/ListHelp
>     <https://help.launchpad.net/ListHelp>
>     > >
> 
> 


References