kicad-developers team mailing list archive

[Chris Pavlina <pavlina.chris@xxxxxxxxx>]

Okay, I'll put it there and push. I wasn't sure it was a good fit there,
but it's better there than hidden away as a static.

On Sun, Jan 07, 2018 at 10:06:16PM +0000, Wayne Stambaugh wrote:
> The best place I can think of is the common/gr_basic.cpp file where all
> of the other wxDC drawing functions reside.
> 
> On 01/07/2018 05:03 PM, Chris Pavlina wrote:
> > Yeah, I was asking if anybody saw a better place for the static function
> > I implemented, it could definitely be moved into common/ where it can be
> > used from elsewhere but I wasn't sure where to put it.
> > 
> > On Sun, Jan 07, 2018 at 10:02:42PM +0000, Wayne Stambaugh wrote:
> >> I tested it on Debian testing and it looks fine to me.
> >>
> >> On 01/07/2018 04:40 PM, Chris Pavlina wrote:
> >>> Yup, I held it back to wait for comments.
> >>>
> >>> On Sun, Jan 07, 2018 at 09:31:06PM +0000, Wayne Stambaugh wrote:
> >>>> Chris,
> >>>>
> >>>> I didn't see this patch in your latest series of pushes.  Is this still
> >>>> relevant?
> >>>>
> >>>> Cheers,
> >>>>
> >>>> Wayne
> >>>>
> >>>> On 01/03/2018 08:55 PM, Chris Pavlina wrote:
> >>>>> Hi,
> >>>>>
> >>>>> The placeholder text that was added to the symbol preview in the chooser
> >>>>> ("double-click here...") has a manually placed line break, making it
> >>>>> flow poorly anywhere the line length doesn't work well --- on my system
> >>>>> with my DPI setting and fonts the line is cut off at almost any
> >>>>> non-ridiculous window sizing. I wrote a small function to wrap text
> >>>>> drawn to a wxDC to fix that.
> >>>>>
> >>>>> I just added this as a static function near where it's used, but if
> >>>>> there's a better place to stick "miscellaneous wxDC helpers" please
> >>>>> advise and I'll move it; I couldn't find a decent spot.
> >>>>>
> >>>>>
> >>>>>
> >>>>> _______________________________________________
> >>>>> Mailing list: https://launchpad.net/~kicad-developers
> >>>>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> >>>>> Unsubscribe : https://launchpad.net/~kicad-developers
> >>>>> More help   : https://help.launchpad.net/ListHelp
> >>>>>
> >>>>
> >>>> _______________________________________________
> >>>> Mailing list: https://launchpad.net/~kicad-developers
> >>>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> >>>> Unsubscribe : https://launchpad.net/~kicad-developers
> >>>> More help   : https://help.launchpad.net/ListHelp