← Back to team overview

kicad-developers team mailing list archive

Re: [PATCH] Implement primitive icon scaling for high DPI

 

Hi Chris,

Patch looks OK on normal-res Retina MacBook Pro (ie: it didn’t break anything).

Cheers,
Jeff.


> On 9 Jan 2018, at 13:44, Nick Østergaard <oe.nick@xxxxxxxxx> wrote:
> 
> I suspect it looks something similar to what is presented in 
> 
> https://bugs.launchpad.net/kicad/+bug/1519581 <https://bugs.launchpad.net/kicad/+bug/1519581>
> 
> 2018-01-09 14:40 GMT+01:00 Bernhard Stegmaier <stegmaier@xxxxxxxxxxxxx <mailto:stegmaier@xxxxxxxxxxxxx>>:
> Hi Chris,
> 
> can you show a screenshot what this patch fixes?
> I have a Retina MacBook and for my taste the toolbar icons are pretty OK without any patch…
> 
> 
> Regards,
> Bernhard
> 
> 
>> On 9. Jan 2018, at 14:27, Maciej Sumiński <maciej.suminski@xxxxxxx <mailto:maciej.suminski@xxxxxxx>> wrote:
>> 
>> Hi Chris,
>> 
>> The patch does not apply cleanly on the current master, would you rebase
>> it? Thanks in advance.
>> 
>> Cheers,
>> Orson
>> 
>> On 01/09/2018 03:43 AM, Chris Pavlina wrote:
>>> Hi,
>>> 
>>> As discussed with Wayne earlier, I've attached a patch which adds simple
>>> toolbar icon scaling so the toolbars are readable on high-DPI systems.
>>> 
>>> This is meant as a stopgap for 5.0, with plans to add proper scaled
>>> icons in the 6.0 cycle. A function KiScaledBitmap() is added, which
>>> works like KiBitmap() except it scales the bitmap according to the
>>> calling window's font size. Controls have been added to all the main
>>> applications to let the user select scaling manually (these were omitted
>>> from smaller apps that didn't already have a place to put them).
>>> 
>>> In addition, in eeschema only, the pixel height of the system font is
>>> shown in the options dialog for diagnostics. This is only for collecting
>>> feedback before 5.0 release from users with different displays and will
>>> be removed.
>>> 
>>> I would like to push this fairly soon, as I want to get as much user
>>> feedback as possible before release. I have a limited number of systems
>>> to test this on myself.
>>> 
>>> 
>>> 
>>> _______________________________________________
>>> Mailing list: https://launchpad.net/~kicad-developers <https://launchpad.net/~kicad-developers>
>>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
>>> Unsubscribe : https://launchpad.net/~kicad-developers <https://launchpad.net/~kicad-developers>
>>> More help   : https://help.launchpad.net/ListHelp <https://help.launchpad.net/ListHelp>
>>> 
>> 
>> 
>> _______________________________________________
>> Mailing list: https://launchpad.net/~kicad-developers <https://launchpad.net/~kicad-developers>
>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
>> Unsubscribe : https://launchpad.net/~kicad-developers <https://launchpad.net/~kicad-developers>
>> More help   : https://help.launchpad.net/ListHelp <https://help.launchpad.net/ListHelp>
> 
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers <https://launchpad.net/~kicad-developers>
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
> Unsubscribe : https://launchpad.net/~kicad-developers <https://launchpad.net/~kicad-developers>
> More help   : https://help.launchpad.net/ListHelp <https://help.launchpad.net/ListHelp>
> 
> 
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp


References