← Back to team overview

kicad-developers team mailing list archive

Re: One more quick plug for reducing "Clarify Selection" dialogs

 

Does the patch resolve your issue?

On 1/9/2018 1:21 PM, kristoffer Ödmark wrote:
> Yes, I can reproduce this with very thick tracks!
> 
> 
> On 2018-01-09 16:55, Jeff Young wrote:
>> Hi Kristoffer,
>>
>> That’s odd.  Did you try it with your mouse pointer directly over the
>> corner?  (You may need a reasonably thick track for this to happen. 
>> Try something on the order of 2mm.)
>>
>> Without my change the selection disambiguation is run *before* we know
>> it’s a drag action on a simple corner, so the selection_tool thinks it
>> needs to know which of the two segments is to be selected.
>>
>> Cheers,
>> Jeff.
>>
>>
>>> On 9 Jan 2018, at 15:37, Kristoffer Ödmark
>>> <kristofferodmark90@xxxxxxxxx> wrote:
>>>
>>> If i understand him correctly that would only be when on a corner, I
>>> think it would be the desired behaviour.
>>>
>>> Although, when I try it on my build on my laptop, there is no clarify
>>> selection menu popping up when trying do drag ( 'd' ) or such on
>>> corners. Not in opengl anywas. So I dont know.
>>>
>>> Application: kicad
>>> Version: (2017-12-30 revision b55eb0b5f)-master, release build
>>> Libraries:
>>>     wxWidgets 3.0.3
>>>     libcurl/7.57.0 OpenSSL/1.1.0g zlib/1.2.11 libidn2/2.0.4
>>> libpsl/0.19.1 (+libidn2/2.0.4) libssh2/1.8.0 nghttp2/1.29.0
>>> Platform: Linux 4.14.12-1-MANJARO x86_64, 64 bit, Little endian, wxGTK
>>> Build Info:
>>>     wxWidgets: 3.0.3 (wchar_t,wx containers,compatible with 2.8) GTK+
>>> 2.24
>>>     Boost: 1.65.1
>>>     Curl: 7.57.0
>>>     Compiler: GCC 7.2.1 with C++ ABI 1011
>>>
>>> Build settings:
>>>     USE_WX_GRAPHICS_CONTEXT=OFF
>>>     USE_WX_OVERLAY=OFF
>>>     KICAD_SCRIPTING=ON
>>>     KICAD_SCRIPTING_MODULES=ON
>>>     KICAD_SCRIPTING_WXPYTHON=ON
>>>     KICAD_SCRIPTING_ACTION_MENU=ON
>>>     BUILD_GITHUB_PLUGIN=ON
>>>     KICAD_USE_OCE=ON
>>>     KICAD_SPICE=ON
>>>
>>>
>>> -Kristoffer
>>>
>>> On 01/09/2018 04:27 PM, Wayne Stambaugh wrote:
>>>> Jeff,
>>>> Have actually confirmed that this is the desired behavior for this
>>>> outside of you own objectives?  I'm not saying that this is or isn't a
>>>> good idea but I personally don't drag trace corners around so I'm not
>>>> sure what the appropriate behavior should be.  You should get comments
>>>> from the dev list and users before you make a change like this.  As far
>>>> as pushing this to the dev repo, if it's not too invasive I will
>>>> consider it.  If it is a large change set, I would prefer that we hold
>>>> off until after the stable release.
>>>> Thanks,
>>>> Wayne
>>>> On 1/8/2018 5:49 AM, Jeff Young wrote:
>>>>> Wayne, if I could get you to don that old project manager’s hat one
>>>>> more time:
>>>>>
>>>>> If we’re still weeks out from declaring an RC, I wanted to make one
>>>>> more plug for getting rid of the Clarify Selection dialog when
>>>>> dragging corners or using ‘U’ or ‘I’ over a corner[1].
>>>>>
>>>>> While it’s marked Wishlist, it seriously impacts productivity when
>>>>> editing tracks, and I think most users would consider it a bug
>>>>> (particularly in the corner case when dragging the corner is
>>>>> clearly moving both the tracks listed in the Clarify Selection menu).
>>>>>
>>>>> I’ve been running the patch for about a week now with no issues.
>>>>>
>>>>> Cheers,
>>>>> Jeff.
>>>>>
>>>>> [1] https://bugs.launchpad.net/kicad/+bug/1708869
>>>>> _______________________________________________
>>>>> Mailing list: https://launchpad.net/~kicad-developers
>>>>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>>>>> Unsubscribe : https://launchpad.net/~kicad-developers
>>>>> More help   : https://help.launchpad.net/ListHelp
>>>>>
>>>> _______________________________________________
>>>> Mailing list: https://launchpad.net/~kicad-developers
>>>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>>>> Unsubscribe : https://launchpad.net/~kicad-developers
>>>> More help   : https://help.launchpad.net/ListHelp
>>> _______________________________________________
>>> Mailing list: https://launchpad.net/~kicad-developers
>>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>>> Unsubscribe : https://launchpad.net/~kicad-developers
>>> More help   : https://help.launchpad.net/ListHelp
> 
> 
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp


Follow ups

References