← Back to team overview

kicad-developers team mailing list archive

Re: [PATCH] Implement primitive icon scaling for high DPI

 

Sure, assign me to it. I should have time to work on it tonight or
tomorrow.

On Wed, Jan 10, 2018 at 04:20:21PM -0500, Wayne Stambaugh wrote:
> FYI, the edit footprint dialog in Pcbnew is not sized properly (at least
> on windows) which I'm pretty sure is related to your recent HiDPI work.
> Do you want me to file a bug report for it?
> 
> On 1/10/2018 2:01 PM, Chris Pavlina wrote:
> > By the way, I'm going to go ahead and push this tonight-ish if nobody
> > objects. I know it's on the big side, but due to my limited number of
> > machines to test on I really want time for user feedback. I'll be around
> > to put out any fires.
> > 
> > On Wed, Jan 10, 2018 at 11:07:49AM -0700, Chris Pavlina wrote:
> >> Rebased patch attached.
> >>
> >> On Tue, Jan 09, 2018 at 01:27:16PM +0000, Maciej Sumiński wrote:
> >>> Hi Chris,
> >>>
> >>> The patch does not apply cleanly on the current master, would you rebase
> >>> it? Thanks in advance.
> >>>
> >>> Cheers,
> >>> Orson
> >>>
> >>> On 01/09/2018 03:43 AM, Chris Pavlina wrote:
> >>>> Hi,
> >>>>
> >>>> As discussed with Wayne earlier, I've attached a patch which adds simple
> >>>> toolbar icon scaling so the toolbars are readable on high-DPI systems.
> >>>>
> >>>> This is meant as a stopgap for 5.0, with plans to add proper scaled
> >>>> icons in the 6.0 cycle. A function KiScaledBitmap() is added, which
> >>>> works like KiBitmap() except it scales the bitmap according to the
> >>>> calling window's font size. Controls have been added to all the main
> >>>> applications to let the user select scaling manually (these were omitted
> >>>> from smaller apps that didn't already have a place to put them).
> >>>>
> >>>> In addition, in eeschema only, the pixel height of the system font is
> >>>> shown in the options dialog for diagnostics. This is only for collecting
> >>>> feedback before 5.0 release from users with different displays and will
> >>>> be removed.
> >>>>
> >>>> I would like to push this fairly soon, as I want to get as much user
> >>>> feedback as possible before release. I have a limited number of systems
> >>>> to test this on myself.
> >>>>
> >>>>
> >>>>
> >>>> _______________________________________________
> >>>> Mailing list: https://launchpad.net/~kicad-developers
> >>>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> >>>> Unsubscribe : https://launchpad.net/~kicad-developers
> >>>> More help   : https://help.launchpad.net/ListHelp
> >>>>
> >>>
> >>>
> >>
> >>
> >>
> > 
> > 
> > _______________________________________________
> > Mailing list: https://launchpad.net/~kicad-developers
> > Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> > Unsubscribe : https://launchpad.net/~kicad-developers
> > More help   : https://help.launchpad.net/ListHelp
> > 
> 
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp


Follow ups

References