kicad-developers team mailing list archive
-
kicad-developers team
-
Mailing list archive
-
Message #33213
Re: [PATCH] Save view control settings before dispatching new tool events
-
To:
<kicad-developers@xxxxxxxxxxxxxxxxxxx>
-
From:
Maciej Sumiński <maciej.suminski@xxxxxxx>
-
Date:
Mon, 15 Jan 2018 10:56:41 +0100
-
Authentication-results:
spf=pass (sender IP is 188.184.36.46) smtp.mailfrom=cern.ch; lists.launchpad.net; dkim=none (message not signed) header.d=none;lists.launchpad.net; dmarc=bestguesspass action=none header.from=cern.ch;
-
In-reply-to:
<CA+qGbCAsBDaBicdYr=TF+Bp=T8dRguPW_XYD6WG84WSmKaub-g@mail.gmail.com>
-
Spamdiagnosticmetadata:
NSPM
-
Spamdiagnosticoutput:
1:99
-
User-agent:
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2
I confirm your patch fixes the problem, so I pushed it to the master
branch. Many thanks for solving another issue!
Regards,
Orson
On 01/12/2018 04:13 AM, Jon Evans wrote:
> Fix another cause of https://bugs.launchpad.net/kicad/+bug/1741357
>
> Using the "add via" hotkey was causing an immediate dispatch of that tool
> event, which was overriding the view settings of the active tool (i.e.
> router tool with cursor displayed).
>
> This patch saves and restores the view settings before dispatching tool
> events, which fixes this and should prevent some other weirdness if one
> tool dispatches another with modified view settings.
>
> -Jon
>
>
>
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help : https://help.launchpad.net/ListHelp
>
Attachment:
signature.asc
Description: OpenPGP digital signature
Follow ups
References
