kicad-developers team mailing list archive

[Kristoffer Ödmark <kristofferodmark90@xxxxxxxxx>]

I just tried the patch, I cannot replicate this behaviour in linux at 
least. Patch works as advertised for me at least.

Application: kicad
Version: (2018-01-16 revision 5571a76e5)-master, release build
Libraries:
    wxWidgets 3.0.3
    libcurl/7.57.0 OpenSSL/1.1.0g zlib/1.2.11 libidn2/2.0.4 
libpsl/0.19.1 (+libidn2/2.0.4) libssh2/1.8.0 nghttp2/1.29.0
Platform: Linux 4.14.13-1-MANJARO x86_64, 64 bit, Little endian, wxGTK
Build Info:
    wxWidgets: 3.0.3 (wchar_t,wx containers,compatible with 2.8) GTK+ 2.24
    Boost: 1.66.0
    Curl: 7.57.0
    Compiler: GCC 7.2.1 with C++ ABI 1011

Build settings:
    USE_WX_GRAPHICS_CONTEXT=OFF
    USE_WX_OVERLAY=OFF
    KICAD_SCRIPTING=ON
    KICAD_SCRIPTING_MODULES=ON
    KICAD_SCRIPTING_WXPYTHON=ON
    KICAD_SCRIPTING_ACTION_MENU=ON
    BUILD_GITHUB_PLUGIN=ON
    KICAD_USE_OCE=ON
    KICAD_SPICE=ON


 -Kristoffer

On 01/16/2018 02:15 PM, Maciej Sumiński wrote:
> I am seeing a different behavior, I think it is best shown on a
> screencast [1]. When I start dragging a footprint, mouse cursor is
> warped back to the drag origin, so the footprint is never moved. If
> footprint was previously selected, then selection is cleared, but it is
> still stuck.
>
> Cheers,
> Orson
>
> 1. https://orson.net.pl/pub/kicad_drag.ogv
>
> On 01/16/2018 01:51 PM, Jeff Young wrote:
> > Hi Orson,
> >
> > Can you say more about the drag issue?
> >
> > If I click in a footprint and drag, it drags the footprint.
> > If I click in a footprint’s pad and drag, it drags the footprint.
> > Same is true whether footprint/pad was previously selected or not.
> > Same is true with trackpad 3-finger drag.
> >
> > Is one of these wrong, or are you seeing different behaviour?
> >
> > Thanks,
> > Jeff.
> >
> > > On 16 Jan 2018, at 12:24, Maciej Sumiński <maciej.suminski@xxxxxxx> wrote:
> > >
> > > Hi Jeff,
> > >
> > > I apologize for long delay. I have just reviewed and tested your patch
> > > and the changes look fine, but there is one thing that needs to be
> > > addressed before they can be accepted. Dragging a footprint with mouse
> > > cursor does not work anymore, cursor simply gets stuck at the drag
> > > origin position. Once it is fixed, I am willing to push your patch.
> > >
> > > Please also consider that attached patch that fixes the code formatting.
> > >
> > > Cheers,
> > > Orson
> > >
> > > On 01/09/2018 06:38 PM, Jeff Young wrote:
> > > > The heat gets bumped up for multiple reports or when people click “this bug affects me too”.
> > > >
> > > > Patch uploaded.
> > > >
> > > > https://bugs.launchpad.net/kicad/+bug/1708869 <https://bugs.launchpad.net/kicad/+bug/1708869>
> > > >
> > > > (The duplicate: https://bugs.launchpad.net/kicad/+bug/1503679 <https://bugs.launchpad.net/kicad/+bug/1503679> )
> > > >
> > > > Cheers,
> > > > Jeff.
> > > >
> > > > > On 9 Jan 2018, at 16:06, Wayne Stambaugh <stambaughw@xxxxxxxxx> wrote:
> > > > >
> > > > > Hey Jeff,
> > > > >
> > > > > I'm not sure what a heat of 22 even means?  I don't see any comments or
> > > > > suggestions in the bug report where lots of devs and/or users gave it a
> > > > > big thumbs up.  I'm talking about getting some input on the concept and
> > > > > testing on a patch from other devs and users.  I can't remember, did you
> > > > > supply a patch for this?  I don't see one on the bug report.  I need to
> > > > > review and test it at a minimum.
> > > > >
> > > > > Cheers,
> > > > >
> > > > > Wayne
> > > > >
> > > > > On 1/9/2018 10:39 AM, Jeff Young wrote:
> > > > > > Hi Wayne,
> > > > > >
> > > > > > Well, the bug has a heat of 22, so it’s definitely not just me. ;)
> > > > > >
> > > > > > My change doesn’t alter the dragging or selecting behaviour.  All it
> > > > > > does is keep an extraneous “Clarify Selection” menu from coming up
> > > > > > (which I think all our users would consider a bug).  What we currently
> > > > > > do in these situations is akin to popping up a “Clarify Selection” menu
> > > > > > with one item in it every time you click on a unambiguous item.
> > > > > >
> > > > > > In the corner case all my change does is prevent us from asking: do you
> > > > > > want to drag the corner of a and b, or do you want to drag the corner of
> > > > > > b and a, when in fact the two have identical semantics).  Everything
> > > > > > after the menu (no matter which item you click) is exactly the same.
> > > > > >
> > > > > > Same with U and I.  My change has no effect on what is selected, it just
> > > > > > keeps us from asking: do you want to select the trivial connection
> > > > > > containing a or do you want to select the trivial connection containing
> > > > > > b, when in fact both a and b are on the /same/ trivial connection.
> > > > > > Again, everything after the menu (no matter which item you click) is
> > > > > > exactly the same.
> > > > > >
> > > > > > Cheers,
> > > > > > Jeff.
> > > > > >
> > > > > > > On 9 Jan 2018, at 15:27, Wayne Stambaugh <stambaughw@xxxxxxxxx
> > > > > > > <mailto:stambaughw@xxxxxxxxx <mailto:stambaughw@xxxxxxxxx>>> wrote:
> > > > > > >
> > > > > > > Jeff,
> > > > > > >
> > > > > > > Have actually confirmed that this is the desired behavior for this
> > > > > > > outside of you own objectives?  I'm not saying that this is or isn't a
> > > > > > > good idea but I personally don't drag trace corners around so I'm not
> > > > > > > sure what the appropriate behavior should be.  You should get comments
> > > > > > > from the dev list and users before you make a change like this.  As far
> > > > > > > as pushing this to the dev repo, if it's not too invasive I will
> > > > > > > consider it.  If it is a large change set, I would prefer that we hold
> > > > > > > off until after the stable release.
> > > > > > >
> > > > > > > Thanks,
> > > > > > >
> > > > > > > Wayne
> > > > > > >
> > > > > > > On 1/8/2018 5:49 AM, Jeff Young wrote:
> > > > > > > > Wayne, if I could get you to don that old project manager’s hat one
> > > > > > > > more time:
> > > > > > > >
> > > > > > > > If we’re still weeks out from declaring an RC, I wanted to make one
> > > > > > > > more plug for getting rid of the Clarify Selection dialog when
> > > > > > > > dragging corners or using ‘U’ or ‘I’ over a corner[1].
> > > > > > > >
> > > > > > > > While it’s marked Wishlist, it seriously impacts productivity when
> > > > > > > > editing tracks, and I think most users would consider it a bug
> > > > > > > > (particularly in the corner case when dragging the corner is clearly
> > > > > > > > moving both the tracks listed in the Clarify Selection menu).
> > > > > > > >
> > > > > > > > I’ve been running the patch for about a week now with no issues.
> > > > > > > >
> > > > > > > > Cheers,
> > > > > > > > Jeff.
> > > > > > > >
> > > > > > > > [1] https://bugs.launchpad.net/kicad/+bug/1708869
> > > > > > > > _______________________________________________
> > > > > > > > Mailing list: https://launchpad.net/~kicad-developers <https://launchpad.net/~kicad-developers>
> > > > > > > > Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
> > > > > > > > <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>>
> > > > > > > > Unsubscribe : https://launchpad.net/~kicad-developers <https://launchpad.net/~kicad-developers>
> > > > > > > > More help   : https://help.launchpad.net/ListHelp <https://help.launchpad.net/ListHelp>
> > > > > > >
> > > > > > > _______________________________________________
> > > > > > > Mailing list: https://launchpad.net/~kicad-developers <https://launchpad.net/~kicad-developers>
> > > > > > > Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
> > > > > > > <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>>
> > > > > > > Unsubscribe : https://launchpad.net/~kicad-developers <https://launchpad.net/~kicad-developers>
> > > > > > > More help   : https://help.launchpad.net/ListHelp <https://help.launchpad.net/ListHelp>
> > > >
> > > >
> > > >
> > > > _______________________________________________
> > > > Mailing list: https://launchpad.net/~kicad-developers
> > > > Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> > > > Unsubscribe : https://launchpad.net/~kicad-developers
> > > > More help   : https://help.launchpad.net/ListHelp
> > >
> > > <0001-Code-formatting-fixes-for-c7e5f0ab.patch>_______________________________________________
> > > Mailing list: https://launchpad.net/~kicad-developers
> > > Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> > > Unsubscribe : https://launchpad.net/~kicad-developers
> > > More help   : https://help.launchpad.net/ListHelp
>
>
>
>
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp