← Back to team overview

kicad-developers team mailing list archive

Re: [PATCH] Defer canvas type setting save until destruction of EDA_DRAW_FRAME

 

For me - not entirely, but definitely it is better than the current
implementation. If you run KiCad for the first time and select 'Enable
hardware acceleration' on a machine that does not support OpenGL, it
switches to Cairo (correctly). Then, when you turn off KiCad, it will
save OpenGL as the default canvas and you will not be able to run pcbnew
again until you manually modify the configuration files (or remove them).

I will have another trial at fixing the problem, finally I have an
environment where I can test different solutions.

Cheers,
Orson

On 01/16/2018 07:04 PM, Chris Pavlina wrote:
> Yes! You got it, works for me :)
> 
> On Tue, Jan 16, 2018 at 05:16:57PM +0000, Chris Pavlina wrote:
>> Sorry I disappeared for a while. I'm building on the machine where I
>> experienced the bug right now.
>>
>> On Tue, Jan 16, 2018 at 04:26:16PM +0000, Jon Evans wrote:
>>> Wayne/Orson, I'm not sure Chris will have time to review this, could you
>>> please take a look?
>>>
>>> Thanks,
>>> Jon
>>>
>>> On Thu, Jan 11, 2018 at 11:02 PM, Jon Evans <jon@xxxxxxxxxxxxx> wrote:
>>>
>>>> Updated patch attached (missed initializers in the original)
>>>>
>>>> On Wed, Jan 10, 2018 at 11:40 PM, Jon Evans <jon@xxxxxxxxxxxxx> wrote:
>>>>
>>>>> Hopefully this fixes:
>>>>> https://bugs.launchpad.net/kicad/+bug/1741787
>>>>> although I don't currently have a good way of reproducing the crash.
>>>>>
>>>>> Chris, if you can give it a try on your crashing machine that would be
>>>>> greatly appreciated.
>>>>>
>>>>> Thanks
>>>>> -Jon
>>>>>
>>>>
>>>>
>>


Follow ups

References