kicad-developers team mailing list archive
-
kicad-developers team
-
Mailing list archive
-
Message #33430
Re: Still banging on about undo....
-
To:
Jeff Young <jeff@xxxxxxxxx>, Kicad Developers <kicad-developers@xxxxxxxxxxxxxxxxxxx>
-
From:
Tomasz Wlostowski <tomasz.wlostowski@xxxxxxx>
-
Date:
Tue, 23 Jan 2018 22:46:37 +0100
-
Authentication-results:
spf=pass (sender IP is 188.184.36.48) smtp.mailfrom=cern.ch; lists.launchpad.net; dkim=none (message not signed) header.d=none;lists.launchpad.net; dmarc=bestguesspass action=none header.from=cern.ch;
-
In-reply-to:
<EE04D925-AA92-43F9-AB29-4F3ED86F9AC6@rokeby.ie>
-
Spamdiagnosticmetadata:
NSPM
-
Spamdiagnosticoutput:
1:99
-
User-agent:
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0
On 23/01/18 22:38, Jeff Young wrote:
> I’d like to get the Drill & Grid origin implementation in for 5.0, and
> I’m happy to volunteer to do the rest for 6.0.
Hi Jeff,
What do you mean by 'the rest'?
Personally, I'm not opposed to undoing grid origin changes, but the 'all
that is in the file' approach you asked about on the forum seems like
going a bit too far for me - for instance I see no need to save changing
layer visibilities in the undo buffer.
I also had a look at the patch - please refactor ORIGIN_VIEWITEM as a
BOARD_ITEM so that the undo buffer needs not know the internals of the
origin object.
Cheers,
Tom
Follow ups
References
