kicad-developers team mailing list archive

[Wayne Stambaugh <stambaughw@xxxxxxxxx>]

Hey Bernhard,

On 01/23/2018 05:51 PM, Bernhard Stegmaier wrote:
> Thanks, Jeff.
>
> So, this brings up a very general question:
> How far do we want to go with patching wxWidgets in our fork?
>
> Don’t get me wrong… the patch looks sane and I guess it then will look 
> on macOS like it does on Linux/Windows - for whatever reason (bug, 
> intended?) it didn’t look like that before.
> Opinions?
> Wayne?

If this is what we have to do to keep macos a workable solution than so 
be it.  I guess at some point in the future, later versions of wx will 
solve these issues but for the time being we can maintain a wx branch 
that gives our macos users the best experience possible.

>  From a pure user perspective I guess it would be more important to have 
> it look/behave the same on all platforms (as long as it doesn’t break OS 
> specific GUI stuff).
> So, I am not opposed to apply such patches and all that might come in 
> future...
>
>
> Regards,
> Bernhard
>
> > On 23. Jan 2018, at 22:30, Jeff Young <jeff@xxxxxxxxx 
> > <mailto:jeff@xxxxxxxxx>> wrote:
> >
> > Thanks, Bernhard.  I tried that, but it didn’t help.
> >
> > I ended up taking out a pretty big hammer: I overrode the 
> > setFrameOrigin method for radioButtons.  When radio buttons are 
> > created in a column-oriented radio box, they now get a wxLEFT style. 
> >  The setFrameOrigin override bangs the x value back to 8 if that flag 
> > is set.
> >
> > Patch in https://bugs.launchpad.net/kicad/+bug/1745026.
> >
> > Cheers,
> > Jeff.
> >
> >
> > > On 23 Jan 2018, at 16:24, Bernhard Stegmaier <stegmaier@xxxxxxxxxxxxx 
> > > <mailto:stegmaier@xxxxxxxxxxxxx>> wrote:
> > >
> > > In wxWidgets master there are a couple of alignment fixes like this one:
> > > https://github.com/wxWidgets/wxWidgets/commit/5aa66ffd936d00d101f12d6e8305a0d2f6c82cc2#diff-4c33f04f2d98bef24c5f526f6fa79d33
> > >
> > > I don’t know if some of them fix that problem.
> > > My last wxWidgets master build shows the same behaviour but I don’t 
> > > know for sure if those fixes were already in.
> > >
> > >
> > > Regards,
> > > Bernhard
> > >
> > > > On 23. Jan 2018, at 15:40, Jeff Young <jeff@xxxxxxxxx 
> > > > <mailto:jeff@xxxxxxxxx>> wrote:
> > > >
> > > > Yeah, it’s just most noticeable in Read Netlist, but in fact it’s 
> > > > all radio buttons in a box sizer:
> > > >
> > > > <PastedGraphic-2.png>
> > > >
> > > > > On 23 Jan 2018, at 14:35, Jeff Young <jeff@xxxxxxxxx 
> > > > > <mailto:jeff@xxxxxxxxx>> wrote:
> > > > >
> > > > > Note: I’ve split the dialog issues out into a separate thread.
> > > > >
> > > > > Hi Wayne,
> > > > >
> > > > > It still happens.  I have wxFormBuilder running, but none of the 
> > > > > settings affect the centering.  I suspect it’s just how the 
> > > > > wxWidgets team implemented it on OSX.
> > > > >
> > > > > I might light at it again while putting my flame-suit on over Undo. ;)
> > > > >
> > > > > Cheers,
> > > > > Jeff.
> > > > >
> > > > >
> > > > > > On 23 Jan 2018, at 14:19, Wayne Stambaugh <stambaughw@xxxxxxxxx 
> > > > > > <mailto:stambaughw@xxxxxxxxx>> wrote:
> > > > > >
> > > > > > Jeff,
> > > > > >
> > > > > > Is this still an issue.  This dialog looks fine on windows and 
> > > > > > linux so
> > > > > > I have no way of confirming that any changes to the wxformbuilder
> > > > > > settings would fix it.  Any of our macos devs have wxformbuilder on
> > > > > > their system so they can fix this?
> > > > > >
> > > > > > Cheers,
> > > > > >
> > > > > > Wayne
> > > > > >
> > > > > > On 1/18/2018 1:17 PM, Jeff Young wrote:
> > > > > > > It’s not center vs. left alignment, but rather that the radio button
> > > > > > > group is centered within the staticTextBox.  Note in particular the
> > > > > > > alignment of the two radio button groups in the left column:
> > > > > > >
> > > > > > >
> > > > > > >
> > > > > > > > On 18 Jan 2018, at 17:23, Nick Østergaard <oe.nick@xxxxxxxxx 
> > > > > > > > <mailto:oe.nick@xxxxxxxxx>
> > > > > > > > <mailto:oe.nick@xxxxxxxxx>> wrote:
> > > > > > > >
> > > > > > > > What do you mean by centered? I don't see anything centered, I just
> > > > > > > > see them left aligned. Looks ok to me unless I am looking at the 
> > > > > > > > wrong
> > > > > > > > thing.
> > > > > > > >
> > > > > > > > 2018-01-14 <tel:20%2018%2001%2014> 0:02 GMT+01:00 Jeff Young
> > > > > > > > <jeff@xxxxxxxxx <mailto:jeff@xxxxxxxxx> <mailto:jeff@xxxxxxxxx>>:
> > > > > > > >
> > > > > > > >   This is a shortcut for eeschema Annotate + eeschema Write Netlist
> > > > > > > >   + pcbnew Read Netlist, right?
> > > > > > > >
> > > > > > > >   Is there a reason the Update PCB from Schematic dialog doesn’t
> > > > > > > >   include the “keep/delete” options we have in the Read Netlist 
> > > > > > > > dialog?
> > > > > > > >
> > > > > > > >   (It appears to mostly do a delete, but not
> > > > > > > >   entirely: https://bugs.launchpad.net/kicad/+bug/1682970
> > > > > > > >   <https://bugs.launchpad.net/kicad/+bug/1682970> )
> > > > > > > >
> > > > > > > >   (Are the Read Netlist dialog radio buttons really meant to be
> > > > > > > >   centered?  They look distinctly odd.)
> > > > > > > >
> > > > > > > >
> > > > > > > >
> > > > > > > >   _______________________________________________
> > > > > > > >   Mailing list: https://launchpad.net/~kicad-developers
> > > > > > > >   <https://launchpad.net/~kicad-developers>
> > > > > > > >   Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx 
> > > > > > > > <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
> > > > > > > >   <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
> > > > > > > >   Unsubscribe : https://launchpad.net/~kicad-developers
> > > > > > > >   <https://launchpad.net/~kicad-developers>
> > > > > > > >   More help   : https://help.launchpad.net/ListHelp
> > > > > > > >   <https://help.launchpad.net/ListHelp>
> > > > > > >
> > > > > > >
> > > > > > >
> > > > > > > _______________________________________________
> > > > > > > Mailing list: https://launchpad.net/~kicad-developers
> > > > > > > Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx 
> > > > > > > <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
> > > > > > > Unsubscribe : https://launchpad.net/~kicad-developers
> > > > > > > More help   : https://help.launchpad.net/ListHelp
> > > > > >
> > > > > > _______________________________________________
> > > > > > Mailing list: https://launchpad.net/~kicad-developers
> > > > > > Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx 
> > > > > > <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
> > > > > > Unsubscribe : https://launchpad.net/~kicad-developers
> > > > > > More help   : https://help.launchpad.net/ListHelp
> > > > >
> > > > >
> > > > >
> > > > > _______________________________________________
> > > > > Mailing list: https://launchpad.net/~kicad-developers
> > > > > Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx 
> > > > > <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
> > > > > Unsubscribe : https://launchpad.net/~kicad-developers
> > > > > More help   : https://help.launchpad.net/ListHelp
> > > >
> > > > _______________________________________________
> > > > Mailing list: https://launchpad.net/~kicad-developers
> > > > Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx 
> > > > <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
> > > > Unsubscribe : https://launchpad.net/~kicad-developers
> > > > More help   : https://help.launchpad.net/ListHelp
>
>
>
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp