kicad-developers team mailing list archive

[Maciej Sumiński <maciej.suminski@xxxxxxx>]

Hi Ludovic,

You did the right thing, normally people send their patches here for
review and proposed changes receive comments or get committed. I have
tested your patch and it works as expected, so I pushed it to the master
branch. Thank you!

One thing I would suggest is to commit your changes locally and use 'git
format-patch' afterwards. This way your patch would also include commit
description and your name in the author field. It makes reviewer life
much easier, especially when it comes to complex patches.

Regards,
Orson

On 01/25/2018 02:21 PM, ludovic léau-mercier wrote:
> Hi, kicad team,
> 
> i'm newbie here.
> 
> I use kicad for simulation with ngspice.
> 
> Currently when you add directive .title in a textbox and generate
> netlist you have this :
> 
> .title KiCad schematic
> QQ1 /collector /base 0 Q_NPN_CBE
> VV1 Net-_V1-Pad1_ 0 dc 0
> VVSENSE1 Net-_V1-Pad1_ /collector dc 0
> II1 0 /base dc 20u
> .title BJT caracteristics
> .model Q_NPN_CBE npn
> .dc vv1 0 50 2 ii1 15u 75u 15u
> .end
> 
> 
> I have create a little patch to replace the default title if exist and
> then you can have :
> 
> .title BJT caracteristics
> QQ1 /collector /base 0 Q_NPN_CBE
> VV1 Net-_V1-Pad1_ 0 dc 0
> VVSENSE1 Net-_V1-Pad1_ /collector dc 0
> II1 0 /base dc 20u
> .model Q_NPN_CBE npn
> .dc vv1 0 50 2 ii1 15u 75u 15u
> .end
> 
> What is the process to suggest this improvement ?
> 
> 
> 
> 
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>

Attachment: signature.asc
Description: OpenPGP digital signature