kicad-developers team mailing list archive
-
kicad-developers team
-
Mailing list archive
-
Message #33489
Re: [PATCH] Save view control settings before dispatching new tool events
-
To:
Jon Evans <jon@xxxxxxxxxxxxx>
-
From:
Maciej Suminski <maciej.suminski@xxxxxxx>
-
Date:
Fri, 26 Jan 2018 19:24:27 +0100
-
Authentication-results:
spf=pass (sender IP is 188.184.36.48) smtp.mailfrom=cern.ch; lists.launchpad.net; dkim=none (message not signed) header.d=none;lists.launchpad.net; dmarc=bestguesspass action=none header.from=cern.ch;
-
Cc:
KiCad Developers <kicad-developers@xxxxxxxxxxxxxxxxxxx>
-
In-reply-to:
<CA+qGbCDUHU8JkoV+T26pfPr7fNJYucFJ5Htm_-mso=bmCtcWAg@mail.gmail.com>
-
Spamdiagnosticmetadata:
NSPM
-
Spamdiagnosticoutput:
1:99
-
User-agent:
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2
Hi Jon,
Apologies, it was a mistake. I have reapplied your patch.
Regards,
Orson
On 01/26/2018 06:14 PM, Jon Evans wrote:
> Hi Orson,
> I saw you just reverted this change in b8ecc95d9c, was that intentional?
> After your commit, issue #1741357 is back.
>
> -Jon
>
> On Mon, Jan 15, 2018 at 4:56 AM, Maciej Sumiński <maciej.suminski@xxxxxxx>
> wrote:
>
>> I confirm your patch fixes the problem, so I pushed it to the master
>> branch. Many thanks for solving another issue!
>>
>> Regards,
>> Orson
>>
>> On 01/12/2018 04:13 AM, Jon Evans wrote:
>>> Fix another cause of https://bugs.launchpad.net/kicad/+bug/1741357
>>>
>>> Using the "add via" hotkey was causing an immediate dispatch of that tool
>>> event, which was overriding the view settings of the active tool (i.e.
>>> router tool with cursor displayed).
>>>
>>> This patch saves and restores the view settings before dispatching tool
>>> events, which fixes this and should prevent some other weirdness if one
>>> tool dispatches another with modified view settings.
>>>
>>> -Jon
>>>
>>>
>>>
>>> _______________________________________________
>>> Mailing list: https://launchpad.net/~kicad-developers
>>> Post to : kicad-developers@xxxxxxxxxxxxxxxxxxx
>>> Unsubscribe : https://launchpad.net/~kicad-developers
>>> More help : https://help.launchpad.net/ListHelp
>>>
>>
>>
>>
>> _______________________________________________
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to : kicad-developers@xxxxxxxxxxxxxxxxxxx
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help : https://help.launchpad.net/ListHelp
>>
>>
>
References