← Back to team overview

kicad-developers team mailing list archive

Re: [PATCH] Save view control settings before dispatching new tool events

 

Hi Jon,

Apologies, it was a mistake. I have reapplied your patch.

Regards,
Orson

On 01/26/2018 06:14 PM, Jon Evans wrote:
> Hi Orson,
> I saw you just reverted this change in b8ecc95d9c, was that intentional?
> After your commit, issue #1741357 is back.
> 
> -Jon
> 
> On Mon, Jan 15, 2018 at 4:56 AM, Maciej Sumiński <maciej.suminski@xxxxxxx>
> wrote:
> 
>> I confirm your patch fixes the problem, so I pushed it to the master
>> branch. Many thanks for solving another issue!
>>
>> Regards,
>> Orson
>>
>> On 01/12/2018 04:13 AM, Jon Evans wrote:
>>> Fix another cause of https://bugs.launchpad.net/kicad/+bug/1741357
>>>
>>> Using the "add via" hotkey was causing an immediate dispatch of that tool
>>> event, which was overriding the view settings of the active tool (i.e.
>>> router tool with cursor displayed).
>>>
>>> This patch saves and restores the view settings before dispatching tool
>>> events, which fixes this and should prevent some other weirdness if one
>>> tool dispatches another with modified view settings.
>>>
>>> -Jon
>>>
>>>
>>>
>>> _______________________________________________
>>> Mailing list: https://launchpad.net/~kicad-developers
>>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>>> Unsubscribe : https://launchpad.net/~kicad-developers
>>> More help   : https://help.launchpad.net/ListHelp
>>>
>>
>>
>>
>> _______________________________________________
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp
>>
>>
> 


References