kicad-developers team mailing list archive

[Wayne Stambaugh <stambaughw@xxxxxxxxx>]

Hey Orson,

LOL!  I just emailed you directly about this less than a minute ago.
Please ignore that message.  I'll get it merged.  Thanks for the reply.

Cheers,

Wayne

On 01/27/2018 08:49 AM, Maciej Suminski wrote:
> Hi Wayne,
> 
> Sorry for late response, I am traveling again. I have not tested the
> patch itself but read the code, mostly focusing on CMP_TREE_MODEL and
> LIB_MANAGER{,_ADAPTER} classes. I think the proposed changes make sense
> and are rather safe. It might be a good idea to merge this patch,
> judging by the testers reactions.
> 
> Cheers,
> Orson
> 
> On 01/26/2018 11:02 PM, Wayne Stambaugh wrote:
>> Orson,
>>
>> Any comments on this?  I would like to get this merged over the weekend.
>>
>> Wayne
>>
>> On 01/26/2018 09:35 AM, Wayne Stambaugh wrote:
>>>
>>>
>>> On 01/26/2018 07:49 AM, jp charras wrote:
>>>> Le 25/01/2018 à 16:24, Jeff Young a écrit :
>>>>> More performance enhancements:
>>>>>
>>>>> 1) Edit Symbol gets similar fix as Place Symbol
>>>>> 2) progress-dialog-updating reduced to once every 50ms
>>>>> 3) SearchText gets lazy normalization
>>>>> 4) translation of typeNames and default fieldNames reduced to a single time
>>>>>
>>>>> These fixes speed first-load-time of both Edit Symbol and Place Symbol by a factor of 3, and
>>>>> second-load-time of Edit Symbol to near-instantaneous.
>>>>>
>>>>> Cheers,
>>>>> Jeff.
>>>>
>>>> Hi Jeff,
>>>>
>>>> It looks good to me.
>>>> I did not find any issue with this patch.
>>>>
>>>> I am waiting for more tests.
>>>>
>>>>
>>>
>>> I just tested this and it looks good to me.  It's had to believe that
>>> the translation lookup was causing that big of a performance hit.  Nice
>>> work!
>>>
>>> @JP, did you check to make sure translations are correct when switching
>>> locales?
>>>
>>> @Orson, are you ok with the changes to the LIB_MANAGER and
>>> LIB_MANAGER_ADAPTER objects.
>>>
>>> If all of this checks out, I will merge this patch.
>>>
>>> Cheers,
>>>
>>> Wayne
>>>
>>
>> _______________________________________________
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp
>>
> 
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>