kicad-developers team mailing list archive

[Bernhard Stegmaier <stegmaier@xxxxxxxxxxxxx>]

Wayne,

yes, from my side you can delete them.
Even if deleted they are in git anyway, so we can restore them if really needed.
I’ll try to change documentation ASAP.


Regards,
Bernhard

> On 29. Jan 2018, at 19:15, Wayne Stambaugh <stambaughw@xxxxxxxxx> wrote:
> 
> Bernhard,
> 
> Am I safe deleting the macos patches from the source repo or do I need
> to hold off until the dust has settle on the new wx repo?
> 
> Thanks,
> 
> Wayne
> 
> On 1/29/2018 1:11 PM, Bernhard Stegmaier wrote:
>> The full original soname patch seems to fix the issue in my builds (I
>> did apply only half of it to our fork because of the comments in
>> wxWidgets trac).
>> I pushed it to the fork.
>> The next build should pick it up automatically and be good again… sorry
>> for not having checked this before.
>> 
>> I also did set the bug to “Fix Committed”.
>> 
>> 
>> BTW @Adam:
>> There are still 2 wxPython macOS patches:
>> (1) The "wxpython-3.0.0_macosx.patch” is not needed as it is the overlay
>> stuff for wxWidgets.
>> (2) I don’t know about the “…_multiarch.patch”. You don’t apply it as
>> far as I can see and it seems to be fine without?
>>   => Still needed?
>> 
>> 
>> Regards,
>> Bernhard
>> 
>> 
>>> On 29. Jan 2018, at 13:47, Bernhard Stegmaier <stegmaier@xxxxxxxxxxxxx
>>> <mailto:stegmaier@xxxxxxxxxxxxx <mailto:stegmaier@xxxxxxxxxxxxx>>> wrote:
>>> 
>>> Just a short status…
>>> I just tried the compile_wx.sh script and it generally seems to be fine.
>>> 
>>> But, I can see that obviously the wxPython installer duplicates libs
>>> instead of symlinking them.
>>> Maybe the original soname patch we had is needed for that one to work
>>> correctly.
>>> I’ll check…
>>> 
>>> 
>>> Regards,
>>> Bernhard
>>> 
>>> 
>>>> On 29. Jan 2018, at 00:32, Adam Wolf <adamwolf@xxxxxxxxxxxxxxxxxxxx <mailto:adamwolf@xxxxxxxxxxxxxxxxxxxx>
>>>> <mailto:adamwolf@xxxxxxxxxxxxxxxxxxxx <mailto:adamwolf@xxxxxxxxxxxxxxxxxxxx>>> wrote:
>>>> 
>>>> I think I see it now.  I can probably fix this tonight.  Thanks!
>>>> 
>>>> Adam
>>>> 
>>>> On Jan 28, 2018 5:30 PM, "Bernhard Stegmaier"
>>>> <stegmaier@xxxxxxxxxxxxx <mailto:stegmaier@xxxxxxxxxxxxx> <mailto:stegmaier@xxxxxxxxxxxxx <mailto:stegmaier@xxxxxxxxxxxxx>>> wrote:
>>>> 
>>>>    Quick look into the build… seems to pull in wrong wxWidgets libs.
>>>>    The build in question includes some 3.0.0 wxWidgets libraries
>>>>    which I guess come from wxPython download.
>>>>    The fork should create 3.0.4 libraries...
>>>> 
>>>>>    On 29. Jan 2018, at 00:05, Bernhard Stegmaier
>>>>>    <stegmaier@xxxxxxxxxxxxx <mailto:stegmaier@xxxxxxxxxxxxx> <mailto:stegmaier@xxxxxxxxxxxxx <mailto:stegmaier@xxxxxxxxxxxxx>>> wrote:
>>>>> 
>>>>>    I just had a quick look and it looks fine.
>>>>> 
>>>>>    Also my first guess is that maybe something got messed up in the
>>>>>    folder hierarchy when copying wxPython/wxWidgets together, so
>>>>>    that e.g. here
>>>>>      WXPYTHON_BUILD_OPTS="WX_CONFIG=`pwd`/../../wx-bin/bin/wx-config \
>>>>>    some wrong wxWidgets (not the one of the fork) gets pulled in.
>>>>> 
>>>>>    Too late here already to check just by review, will try tomorrow… :)
>>>>> 
>>>>>>    On 29. Jan 2018, at 00:00, Adam Wolf
>>>>>>    <adamwolf@xxxxxxxxxxxxxxxxxxxx <mailto:adamwolf@xxxxxxxxxxxxxxxxxxxx>
>>>>>>    <mailto:adamwolf@xxxxxxxxxxxxxxxxxxxx <mailto:adamwolf@xxxxxxxxxxxxxxxxxxxx>>> wrote:
>>>>>> 
>>>>>>    Yeah.  The previous build script downloaded a wxpython tarball,
>>>>>>    which included wxwidgets.
>>>>>> 
>>>>>>    All my update did was move the wxpython subdirectory into a git
>>>>>>    checkout of the wxwidgets tree, and build that way.
>>>>>> 
>>>>>>    One quick thing would be to just do a diff between the
>>>>>>    wxwidgets included with wxpython 3.0.2.0, and the tree.  At
>>>>>>    this point, nothing would surprise me :)
>>>>>> 
>>>>>>    Adam
>>>>>> 
>>>>>> 
>>>>>> 
>>>>>>    On Jan 28, 2018 4:54 PM, "Bernhard Stegmaier"
>>>>>>    <stegmaier@xxxxxxxxxxxxx <mailto:stegmaier@xxxxxxxxxxxxx> <mailto:stegmaier@xxxxxxxxxxxxx <mailto:stegmaier@xxxxxxxxxxxxx>>> wrote:
>>>>>> 
>>>>>>        Sure.
>>>>>>        I’ll have a look tomorrow and try to build
>>>>>>        wxWidgets/wxPython the same way the script does.
>>>>>> 
>>>>>>>        On 28. Jan 2018, at 23:44, Nick Østergaard
>>>>>>>        <oe.nick@xxxxxxxxx <mailto:oe.nick@xxxxxxxxx> <mailto:oe.nick@xxxxxxxxx <mailto:oe.nick@xxxxxxxxx>>> wrote:
>>>>>>> 
>>>>>>>        You don't need to revert it. I can just choose the latest
>>>>>>>        workin hash in the jenkins job. I would rather we fix it
>>>>>>>        somehow. :)
>>>>>>> 
>>>>>>>        @Bernhard, the build scripts in question are
>>>>>>>        https://github.com/wayneandlayne/KiCadMacOSPackaging <https://github.com/wayneandlayne/KiCadMacOSPackaging>
>>>>>>>        <https://github.com/wayneandlayne/KiCadMacOSPackaging <https://github.com/wayneandlayne/KiCadMacOSPackaging>>
>>>>>>> 
>>>>>>>        Maybe you can have a got at it?
>>>>>>> 
>>>>>>>        2018-01-28 23:41 GMT+01:00 Nick Østergaard
>>>>>>>        <oe.nick@xxxxxxxxx <mailto:oe.nick@xxxxxxxxx> <mailto:oe.nick@xxxxxxxxx <mailto:oe.nick@xxxxxxxxx>>>:
>>>>>>> 
>>>>>>>            I assume this is the bug you are talking about:
>>>>>>>            https://bugs.launchpad.net/kicad/+bug/1745868 <https://bugs.launchpad.net/kicad/+bug/1745868>
>>>>>>>            <https://bugs.launchpad.net/kicad/+bug/1745868 <https://bugs.launchpad.net/kicad/+bug/1745868>>
>>>>>>> 
>>>>>>>            2018-01-28 23:14 GMT+01:00 Adam Wolf
>>>>>>>            <adamwolf@xxxxxxxxxxxxxxxxxxxx <mailto:adamwolf@xxxxxxxxxxxxxxxxxxxx>
>>>>>>>            <mailto:adamwolf@xxxxxxxxxxxxxxxxxxxx <mailto:adamwolf@xxxxxxxxxxxxxxxxxxxx>>>:
>>>>>>> 
>>>>>>>                I was able to get the wxwidgets stuff switched
>>>>>>>                over but there's a bug in the big tracker saying
>>>>>>>                it didn't work.  I will continue to look into it
>>>>>>>                as I can.  I should be over this illness by the
>>>>>>>                end of this week, it looks like.
>>>>>>> 
>>>>>>>                I can revert the packaging change so the next
>>>>>>>                builds will work again.
>>>>>>> 
>>>>>>>                Sorry folks, I have lost weeks and weeks of
>>>>>>>                productivity and am trying to do my best.
>>>>>>> 
>>>>>>>                Adam
>>>>>>> 
>>>>>>>                _______________________________________________
>>>>>>>                Mailing list:
>>>>>>>                https://launchpad.net/~kicad-developers <https://launchpad.net/~kicad-developers>
>>>>>>>                <https://launchpad.net/~kicad-developers <https://launchpad.net/~kicad-developers>>
>>>>>>>                Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
>>>>>>>                <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>>
>>>>>>>                Unsubscribe :
>>>>>>>                https://launchpad.net/~kicad-developers <https://launchpad.net/~kicad-developers>
>>>>>>>                <https://launchpad.net/~kicad-developers <https://launchpad.net/~kicad-developers>>
>>>>>>>                More help   : https://help.launchpad.net/ListHelp <https://help.launchpad.net/ListHelp>
>>>>>>>                <https://help.launchpad.net/ListHelp <https://help.launchpad.net/ListHelp>>
>>>>>>> 
>>>>>>> 
>>>>>>> 
>>>>>>>        _______________________________________________
>>>>>>>        Mailing list: https://launchpad.net/~kicad-developers <https://launchpad.net/~kicad-developers>
>>>>>>>        <https://launchpad.net/~kicad-developers <https://launchpad.net/~kicad-developers>>
>>>>>>>        Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
>>>>>>>        <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>>
>>>>>>>        Unsubscribe : https://launchpad.net/~kicad-developers <https://launchpad.net/~kicad-developers>
>>>>>>>        <https://launchpad.net/~kicad-developers <https://launchpad.net/~kicad-developers>>
>>>>>>>        More help   : https://help.launchpad.net/ListHelp <https://help.launchpad.net/ListHelp>
>>>>>>>        <https://help.launchpad.net/ListHelp <https://help.launchpad.net/ListHelp>>
>>>>>> 
>>>>> 
>>>>>    _______________________________________________
>>>>>    Mailing list: https://launchpad.net/~kicad-developers <https://launchpad.net/~kicad-developers>
>>>>>    <https://launchpad.net/~kicad-developers <https://launchpad.net/~kicad-developers>>
>>>>>    Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
>>>>>    <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>>
>>>>>    Unsubscribe : https://launchpad.net/~kicad-developers <https://launchpad.net/~kicad-developers>
>>>>>    <https://launchpad.net/~kicad-developers <https://launchpad.net/~kicad-developers>>
>>>>>    More help   : https://help.launchpad.net/ListHelp <https://help.launchpad.net/ListHelp>
>>>>>    <https://help.launchpad.net/ListHelp <https://help.launchpad.net/ListHelp>>
>>>> 
>>> 
>>> _______________________________________________
>>> Mailing list: https://launchpad.net/~kicad-developers <https://launchpad.net/~kicad-developers>
>>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
>>> <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>>
>>> Unsubscribe : https://launchpad.net/~kicad-developers
>>> More help   : https://help.launchpad.net/ListHelp
>> 
>> 
>> 
>> _______________________________________________
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp
>> 
> 
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp