← Back to team overview

kicad-developers team mailing list archive

Re: [PATCH] Allow low-cost reordering of view layers (for Gerber X2 sorting)

 

Interesting, I will have to boot up my windows machine and see if I have
the same result.

Thanks for testing!

Jon

On Feb 5, 2018 04:56, "jp charras" <jp.charras@xxxxxxxxxx> wrote:

> Le 04/02/2018 à 22:44, Jon Evans a écrit :
> > As JP has noted, the "sort layers by X2 attributes" feature is really
> slow in GAL mode when you are
> > looking at a complicated set of Gerber files.
> >
> > This is because there was previously no way to swap around data between
> layer IDs without removing
> > and re-adding that data.
> >
> > The attached patch implements a reordering mechanism and speeds up the
> X2 sorting by ~20x on my machine.
> >
> > JP/Orson/others, please take a look and let me know if you have any
> concerns with it.
> >
> > Thanks,
> > Jon
>
> Hi Jon,
>
> I tested the patch on W7 -32 bits.
>
> Unfortunately, it does not work as expected:
>
> I loaded 2 Gerber files and switch from Cairo to OpenGL (reorder X2
> command gives similar results):
> current version (without patch): calculation time 12 to 15 seconds
> with patch: calculation time about 2 minutes.
>
>
> --
> Jean-Pierre CHARRAS
>
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>

References