kicad-developers team mailing list archive

[Wayne Stambaugh <stambaughw@xxxxxxxxx>]

Thanks for testing this.  I know I'm being paranoid but we've been bit
by this before.  Maybe someday our unit testing will actually get
implemented.

Wayne

On 2/7/2018 8:21 AM, Russell Oliver wrote:
> I just tested printing then and it worked fine. plus one person's
> unhandled edge case is another's unit test. 
> 
> 
> 
> On Thu, Feb 8, 2018 at 12:05 AM Wayne Stambaugh <stambaughw@xxxxxxxxx
> <mailto:stambaughw@xxxxxxxxx>> wrote:
> 
>     Be careful with zero length line segments.  They have been known to
>     cause issues in the past.  We recently fixed a print bug where a zero
>     diameter circle was causing pages not to print.
> 
>     On 2/7/2018 7:45 AM, Russell Oliver wrote:
>     > Hi Orson, 
>     >
>     > I'm completely fine with any simplifications and style changes. 
>     >
>     > With regards to the zero length line, it appears on line 110 of your
>     > patch file. 
>     > 110: +    "(line (name segm1:Line) (start 0 0) (end 0 0))\n" 
>     >
>     > JP mentions in a comment to the bug report that there is a legacy
>     > compatibility requirement to have at least one item in the page
>     layout,
>     > otherwise the default layout it used. This was for old schematics that
>     > do not have a page layout specified. 
>     >
>     > Kind Regards
>     > Russell
>     >
>     >
>     > On Wed, Feb 7, 2018 at 12:13 AM Maciej Sumiński
>     <maciej.suminski@xxxxxxx <mailto:maciej.suminski@xxxxxxx>
>     > <mailto:maciej.suminski@xxxxxxx <mailto:maciej.suminski@xxxxxxx>>>
>     wrote:
>     >
>     >     Hi Russell,
>     >
>     >     Thank you very much for the patch. It works as expected and I
>     would like
>     >     to merge it, but there are two things.
>     >
>     >     I have simplified the patch a bit (moved the empty layout to
>     an existing
>     >     file, minor code formatting fixes), so please confirm you are
>     ok with
>     >     committing it under your name.
>     >
>     >     Another question is about "there is a 0 length line to fool
>     something
>     >     somewhere." comment for const char emptyLayout[]. Could you say
>     >     something more about it? I could not spot a 0 length line in
>     the layout
>     >     description, so perhaps we can remove it to avoid confusion.
>     >
>     >     Regards,
>     >     Orson
>     >
>     >     On 02/03/2018 01:27 AM, Russell Oliver wrote:
>     >     > Attached is a patch that adds an empty layout using the same
>     >     method as the
>     >     > SetDefaultLayout function, which is then called by the Eagle
>     schematic
>     >     > plugin to leave only the imported frame visible.
>     >     >
>     >     > https://bugs.launchpad.net/kicad/+bug/1729722
>     >     >
>     >     > Kind Regards
>     >     > Russell
>     >     >
>     >     >
>     >     >
>     >     > _______________________________________________
>     >     > Mailing list: https://launchpad.net/~kicad-developers
>     >     > Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>     <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
>     >     <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx
>     <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>>
>     >     > Unsubscribe : https://launchpad.net/~kicad-developers
>     >     > More help   : https://help.launchpad.net/ListHelp
>     >     >
>     >
>     >     _______________________________________________
>     >     Mailing list: https://launchpad.net/~kicad-developers
>     >     Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>     <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
>     >     <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx
>     <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>>
>     >     Unsubscribe : https://launchpad.net/~kicad-developers
>     >     More help   : https://help.launchpad.net/ListHelp
>     >
>     >
>     >
>     > _______________________________________________
>     > Mailing list: https://launchpad.net/~kicad-developers
>     > Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>     <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
>     > Unsubscribe : https://launchpad.net/~kicad-developers
>     > More help   : https://help.launchpad.net/ListHelp
>     >
> 
>     _______________________________________________
>     Mailing list: https://launchpad.net/~kicad-developers
>     Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>     <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
>     Unsubscribe : https://launchpad.net/~kicad-developers
>     More help   : https://help.launchpad.net/ListHelp
>