kicad-developers team mailing list archive

[Maciej Sumiński <maciej.suminski@xxxxxxx>]

Jon,

I have not noticed much change in performance on Linux or Windows, but
if there is a speed up on macOS, then it is worth merging. The change
seems quite safe (famous last words), so I merged your patch. Thank you!

Regards,
Orson

On 01/29/2018 06:42 PM, Jon Evans wrote:
> I have been working on https://bugs.launchpad.net/kicad/+bug/1745203
> looking for ways to squeeze performance out of rendering large numbers of
> items on the GAL canvas.
> 
> The attached patch is the first "low-risk" change I have found.  This
> change results in a 10-15% speedup in operations (file load, show/hide
> d-codes, etc) on MacOS.  The change is somewhat less dramatic on Linux, and
> I have not tested it on Windows.
> 
> The rationale for the change is that iterating over a std::bitset is
> somewhat costly, and most items don't exist on that many layers, so I am
> trading time for memory but I don't see it as a large memory cost.
> 
> -Jon
> 
> 
> 
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>

Attachment: signature.asc
Description: OpenPGP digital signature