← Back to team overview

kicad-developers team mailing list archive

Re: [PATCH] Pcbnew menu bar

 

Lets start with these for now. Patches address a spelling error in the
code, edit, file and view menus, removes duplicate items and adds missing
tools.

Please let me know your comments.

Regards,
Michael

On 14 February 2018 at 21:55, Michael Kavanagh <michael@xxxxxxxxxxxxxxxxxx>
wrote:
> Okay thanks. Also I think I messed up even the simple first patch (git
> n00b over here). Please await an updated patch set.
>
> Cheers,
> Michael
>
> On 14 February 2018 at 21:30, Wayne Stambaugh <stambaughw@xxxxxxxxx>
wrote:
>> Michael,
>>
>> For future reference, please try to avoid posting a large patch set like
>> this.  I makes it difficult to comment on them without the email thread
>> quickly becoming difficult to follow.  Also, please make an announcement
>> on the mailing when making substantial changes like this.  You could
>> have gotten the feedback first which would have saved you some work.
>>
>> Thanks,
>>
>> Wayne
>>
>> On 2/13/2018 5:46 PM, Michael Kavanagh wrote:
>>> Hi,
>>>
>>> I tried to fix up the Pcbnew menu bar a bit so its more "standards
>>> complaint" with regards to UI and also include options where there are
>>> toolbar buttons but no menu bar item.
>>>
>>> Tried to keep commits small, hence number of patches.
>>>
>>> Regards,
>>> Michael
>>>
>>>
>>> _______________________________________________
>>> Mailing list: https://launchpad.net/~kicad-developers
>>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>>> Unsubscribe : https://launchpad.net/~kicad-developers
>>> More help   : https://help.launchpad.net/ListHelp
>>>
>>
>> _______________________________________________
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp

Attachment: 0001-Fix-spelling-error.patch
Description: Binary data

Attachment: 0002-Improve-edit-menu-and-use-common-hotkeys.patch
Description: Binary data

Attachment: 0003-Fix-up-file-menu-and-hotkeys.patch
Description: Binary data

Attachment: 0004-Remove-duplicate-track-menu-item.patch
Description: Binary data

Attachment: 0005-Add-missing-tools-to-menubar.patch
Description: Binary data

Attachment: 0006-Add-missing-items-to-view-menu-and-improve.patch
Description: Binary data

Attachment: 0007-Remove-duplicate-menu-item.patch
Description: Binary data


Follow ups

References