kicad-developers team mailing list archive

[Michael Kavanagh <michael@xxxxxxxxxxxxxxxxxx>]

Thanks for that Orson, and sorry for causing so much confusion everyone.
Lesson learnt. Also thanks Jeff for helping with the dialog change.

I'll pause for feedback and we can address the rest of the patches one by
one. For context here is what I suggest:

   - File: as per 0003-Fix-up-file-menu-and-hotkeys.patch
   - View: see 0006-Add-missing-items-to-view-menu-and-improve.patch
   - Setup: collect project/pcb specific settings into this menu
   - Layers Setup...
      - Design Rules...
      - -------------------
      - Footprint Library Wizard
      - Footprint Library Table
      - -------------------
      - Dimensions
         - User Defined Grid...
         - Text and Drawings...
         - Default Pad Properties...
         - Pads to Mask Clearance...
         - Differential Pairs...
      - Place: as per 0005-Add-missing-tools-to-menubar.patch
   - Footprint
      - Via
      - Zone
      - Keepout Area
      - Text
      - Arc
      - Circle
      - Lines
      - Polygons
      - ------------
      - Dimension
      - Layer Alignment Target
      - ------------
      - Drill and Place Offset
      - Grid Origin
   - Route: leave as is
   - Inspect: created in 0005-Add-missing-tools-to-menubar.patch containing
   just Measure tool, add
      - Design Rules Checker
      - ---------------
      - Measure
      - List nets
   - Tools
      -
      - Preferences: reserved for suite/application settings eg
      - Paths
      - Display settings...
      - Icons
      - Languages
   - Help

Hopefully this provides some context/alleviates some confusion. With what I
suggest menu bar items follow a logical design flow:
Setup -> Place -> Route -> Inspect
Obviously, real life is never so perfect...

Regards,
Michael


On 15 February 2018 at 19:42, Wayne Stambaugh <stambaughw@xxxxxxxxx> wrote:

> It appears in this case that they are being used as hotkeys rather than
> menu accelerators so no change is necessary.
>
> On 2/15/2018 11:40 AM, Maciej Sumiński wrote:
> > Hi Wayne,
> >
> > I am not sure if there is an issue, I think cut/copy/paste are genuine
> > hotkeys and not just accelerators, unless you have something else in
> > mind. In any case, I have committed patch 0002 as is it was sent here.
> >
> > Cheers,
> > Orson
> >
> > On 02/15/2018 05:31 PM, Wayne Stambaugh wrote:
> >> Orson,
> >>
> >> Did you fix the IS_ACCELERATOR issue in patch 0002 when calling
> >> AddHotkeyName()?
> >>
> >> Wayne
> >>
> >> On 2/15/2018 11:00 AM, Maciej Sumiński wrote:
> >>> To reduce the discussion scope, I have committed the obvious
> improvements:
> >>> 0001-Fix-spelling-error.patch
> >>> 0002-Improve-edit-menu-and-use-common-hotkeys.patch
> >>> 0004-Remove-duplicate-track-menu-item.patch
> >>>
> >>> To be discussed:
> >>> 0003-Fix-up-file-menu-and-hotkeys.patch
> >>> 0005-Add-missing-tools-to-menubar.patch
> >>> 0006-Add-missing-items-to-view-menu-and-improve.patch
> >>> 0007-Remove-duplicate-menu-item.patch
> >>>
> >>> 0005-Grid-dialog-changes-to-go-along-with-menu-changes.patch (Jeff)
> >>>
> >>> Cheers,
> >>> Orson
> >>>
> >>>
> >>> On 02/15/2018 02:46 PM, Michael Kavanagh wrote:
> >>>> Was this what you meant?
> >>>>
> >>>> On 15 February 2018 at 11:15, Jeff Young <jeff@xxxxxxxxx> wrote:
> >>>>
> >>>>> Hi Michael,
> >>>>>
> >>>>> Only thing I found wrong was that you have Sketch & Wireframe zones
> >>>>> backwards:
> >>>>>
> >>>>> Wireframe == ID_TB_OPTIONS_SHOW_ZONES_DISABLE
> >>>>>
> >>>>> Sketch == ID_TB_OPTIONS_SHOW_ZONES_OUTLINES_ONLY
> >>>>>
> >>>>>
> >>>>> On the opinion side, the Inspect menu is growing on me.  So if no
> one else
> >>>>> has objections to it, then I’ll shut up. ;)
> >>>>>
> >>>>> Cheers,
> >>>>> Jeff.
> >>>>>
> >>>>>
> >>>>> On 15 Feb 2018, at 01:00, Michael Kavanagh <
> michael@xxxxxxxxxxxxxxxxxx>
> >>>>> wrote:
> >>>>>
> >>>>> Lets start with these for now. Patches address a spelling error in
> the
> >>>>> code, edit, file and view menus, removes duplicate items and adds
> missing
> >>>>> tools.
> >>>>>
> >>>>> Please let me know your comments.
> >>>>>
> >>>>> Regards,
> >>>>> Michael
> >>>>>
> >>>>> On 14 February 2018 at 21:55, Michael Kavanagh <
> michael@xxxxxxxxxxxxxxxxxx>
> >>>>> wrote:
> >>>>>> Okay thanks. Also I think I messed up even the simple first patch
> (git
> >>>>>> n00b over here). Please await an updated patch set.
> >>>>>>
> >>>>>> Cheers,
> >>>>>> Michael
> >>>>>>
> >>>>>> On 14 February 2018 at 21:30, Wayne Stambaugh <stambaughw@xxxxxxxxx
> >
> >>>>> wrote:
> >>>>>>> Michael,
> >>>>>>>
> >>>>>>> For future reference, please try to avoid posting a large patch
> set like
> >>>>>>> this.  I makes it difficult to comment on them without the email
> thread
> >>>>>>> quickly becoming difficult to follow.  Also, please make an
> announcement
> >>>>>>> on the mailing when making substantial changes like this.  You
> could
> >>>>>>> have gotten the feedback first which would have saved you some
> work.
> >>>>>>>
> >>>>>>> Thanks,
> >>>>>>>
> >>>>>>> Wayne
> >>>>>>>
> >>>>>>> On 2/13/2018 5:46 PM, Michael Kavanagh wrote:
> >>>>>>>> Hi,
> >>>>>>>>
> >>>>>>>> I tried to fix up the Pcbnew menu bar a bit so its more "standards
> >>>>>>>> complaint" with regards to UI and also include options where
> there are
> >>>>>>>> toolbar buttons but no menu bar item.
> >>>>>>>>
> >>>>>>>> Tried to keep commits small, hence number of patches.
> >>>>>>>>
> >>>>>>>> Regards,
> >>>>>>>> Michael
> >>>>>>>>
> >>>>>>>>
> >>>>>>>> _______________________________________________
> >>>>>>>> Mailing list: https://launchpad.net/~kicad-developers
> >>>>>>>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> >>>>>>>> Unsubscribe : https://launchpad.net/~kicad-developers
> >>>>>>>> More help   : https://help.launchpad.net/ListHelp
> >>>>>>>>
> >>>>>>>
> >>>>>>> _______________________________________________
> >>>>>>> Mailing list: https://launchpad.net/~kicad-developers
> >>>>>>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> >>>>>>> Unsubscribe : https://launchpad.net/~kicad-developers
> >>>>>>> More help   : https://help.launchpad.net/ListHelp
> >>>>>
> >>>>> <0001-Fix-spelling-error.patch><0002-Improve-edit-menu-
> >>>>> and-use-common-hotkeys.patch><0003-Fix-up-file-menu-and-hotk
> eys.patch>
> >>>>> <0004-Remove-duplicate-track-menu-item.patch><0005-Add-missi
> ng-tools-
> >>>>> to-menubar.patch><0006-Add-missing-items-to-view-menu-and-im
> prove.patch>
> >>>>> <0007-Remove-duplicate-menu-item.patch>________________________
> >>>>> _______________________
> >>>>> Mailing list: https://launchpad.net/~kicad-developers
> >>>>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> >>>>> Unsubscribe : https://launchpad.net/~kicad-developers
> >>>>> More help   : https://help.launchpad.net/ListHelp
> >>>>>
> >>>>>
> >>>>>
> >>>>
> >>>>
> >>>>
> >>>> _______________________________________________
> >>>> Mailing list: https://launchpad.net/~kicad-developers
> >>>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> >>>> Unsubscribe : https://launchpad.net/~kicad-developers
> >>>> More help   : https://help.launchpad.net/ListHelp
> >>>>
> >>>
> >>>
> >>>
> >>>
> >>> _______________________________________________
> >>> Mailing list: https://launchpad.net/~kicad-developers
> >>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> >>> Unsubscribe : https://launchpad.net/~kicad-developers
> >>> More help   : https://help.launchpad.net/ListHelp
> >>>
> >>
> >> _______________________________________________
> >> Mailing list: https://launchpad.net/~kicad-developers
> >> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> >> Unsubscribe : https://launchpad.net/~kicad-developers
> >> More help   : https://help.launchpad.net/ListHelp
> >>
> >
> >
> >
> >
> > _______________________________________________
> > Mailing list: https://launchpad.net/~kicad-developers
> > Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> > Unsubscribe : https://launchpad.net/~kicad-developers
> > More help   : https://help.launchpad.net/ListHelp
> >
>
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>