← Back to team overview

kicad-developers team mailing list archive

Re: [PATCH] Pcbnew menu bar

 

On 02/16/2018 03:29 PM, Jeff Young wrote:
Is 0003-Fix-up-file-menu-and-hotkeys.patch suitable for merging straight away?

Yes, I believe it is.

AddHotkeyName() should be specified with IS_ACCELERATOR because New, Save, Save As, etc. are menu accelerators not hotkeys so that needs to be fixed before this patch can be merged.


Cheers,
Jeff.


On 16 Feb 2018, at 19:31, Michael Kavanagh <michael@xxxxxxxxxxxxxxxxxx> wrote:

Footprint library table is has a global part yes, but its still to do
with the PCB being designed and not the application, so IMO belongs in
the setup menu.

Regardless, I'll work on the revised plans this weekend, and move
"Grid Settings..." to the view menu.

Is 0003-Fix-up-file-menu-and-hotkeys.patch suitable for merging straight away?

On 16 February 2018 at 17:02, Jeff Young <jeff@xxxxxxxxx> wrote:
Here’s the second set of dialog changes to go with the menu changes:

Move sketch mode stuff from "Display Settings" to View menu.
Move "Icons in Menus" from View menu to "General Preferences".
Move "Icon Scaling" from "Display Settings" to "General Preferences".
Do some regrouping in both dialogs for better comprehension.





On 16 Feb 2018, at 16:12, Wayne Stambaugh <stambaughw@xxxxxxxxx> wrote:

Hey Jeff,

I agree with these changes so as soon as Michael posts the revised
patches, we can get them reviewed and I can merge them.  Thanks for
helping out with the patch review.  I appreciate the help.

Cheers,

Wayne

On 2/16/2018 10:47 AM, Jeff Young wrote:

Hi Wayne,

With these changes:

   “Footprint Library Wizard” and “Footprint Library Table” are
   environmental settings so they belong under Preferences, not Setup.
    That (and moving “User Defined Grid…”) should make it short enough
   not to need the nested menu for Dimensions.

   I still feel strongly that “User Defined Grid…” belongs in the View
   menu under “Show Grid” (and should be renamed “Grid Settings…”).

   Same for “Interactive Routing…” moving to the Route menu (and
   perhaps becoming “Router Settings…”).  Context (putting things that
   are used together near each other) is more important than taxonomy
   (arranging by logical grouping).

   For a drop-down menu, the first item is the hardest to select while
   the second is the easiest.  So for Inspect I’d suggest:

   Inspect
      List Nets
      Measure
      ——————————
      Design Rules Checker


I’m ready to go with it.  I haven’t heard back from Michael yet, and I
don’t know what his turn-around time is.   He’s been pretty responsive
so far, though.

I could also make the changes, but I don’t want to step on his stuff….

Cheers,
Jeff.





_______________________________________________
Mailing list: https://launchpad.net/~kicad-developers
Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp



References