| Thread Previous • Date Previous • Date Next • Thread Next |
Thanks Wayne. Please don't forget to merge Jeffs dialog changes which complete the Pcbnew menubar modifications. I have reattached them to this email for convenience. Cheers, Michael On 18 February 2018 at 19:16, Wayne Stambaugh <stambaughw@xxxxxxxxx> wrote: > Michael, > > I figured out why we are not using IS_ACCELERATOR for these menu entries. > AddHotkeyName() adds a "+Alt+" to the hotkey so this is *not* what we want > so I used the original 0003 patch. I apologize for the confusion. I merged > this and you 0004 patch. We can make any tweaks to it if it's not exactly > what we want. Thank you for your contribution to KiCad. > > Cheers, > > Wayne > > > On 02/18/2018 10:10 AM, Michael Kavanagh wrote: >> >> In every other app New, Open, Save, Save As and Print are standard >> hotkeys and not accelerators. They don't have the modifier key, so are >> the "standard" keyboard shortcuts. >> >> Nevertheless, please find attached new patches for review. These >> accompany both of Jeffs dialog patches. Hopefully I didn't break >> anything, implementing the sketch modes removed from the dialogs >> involved fiddling with the GAL tools framework. >> >> Cheers, >> Michael >> >> On 17 February 2018 at 17:27, Wayne Stambaugh <stambaughw@xxxxxxxxx> >> wrote: >>> >>> It should be. We really need to get out of the bad habit of having >>> toolbar only access to tools and settings. I'm sure there are some in >>> the schematic editor, symbol editor, and footprint editor as well. >>> >>> On 02/17/2018 06:16 AM, Jeff Young wrote: >>>> >>>> The Fill/Outline stuff is included. Not sure about High Contrast mode, >>>> but it probably should be. >>>> >>>>> On 17 Feb 2018, at 06:58, Gaurav Juvekar <gauravjuvekar@xxxxxxxxx> >>>>> wrote: >>>>> >>>>> Hi all, >>>>> >>>>> Probably not too relevant, but can we have a workaround of >>>>> https://bugs.launchpad.net/kicad/+bug/1575097 (hidden icons) by adding >>>>> View -> High Contrast (Checkable like the "Flip board view") >>>>> View -> Tracks -> Outline (Radio button like the canvas selector) >>>>> -> Fill >>>>> View -> Vias -> Outline >>>>> -> Fill >>>>> View -> Pads -> Outline >>>>> -> Fill >>>>> >>>>> to the menu entries? >>>>> >>>>> -- >>>>> Regards, >>>>> Gaurav Juvekar >>>>> >>>>> _______________________________________________ >>>>> Mailing list: https://launchpad.net/~kicad-developers >>>>> Post to : kicad-developers@xxxxxxxxxxxxxxxxxxx >>>>> Unsubscribe : https://launchpad.net/~kicad-developers >>>>> More help : https://help.launchpad.net/ListHelp >>>> >>>> >>>> >>>> _______________________________________________ >>>> Mailing list: https://launchpad.net/~kicad-developers >>>> Post to : kicad-developers@xxxxxxxxxxxxxxxxxxx >>>> Unsubscribe : https://launchpad.net/~kicad-developers >>>> More help : https://help.launchpad.net/ListHelp >>>> >>> >>> _______________________________________________ >>> Mailing list: https://launchpad.net/~kicad-developers >>> Post to : kicad-developers@xxxxxxxxxxxxxxxxxxx >>> Unsubscribe : https://launchpad.net/~kicad-developers >>> More help : https://help.launchpad.net/ListHelp >>> >>> >>> _______________________________________________ >>> Mailing list: https://launchpad.net/~kicad-developers >>> Post to : kicad-developers@xxxxxxxxxxxxxxxxxxx >>> Unsubscribe : https://launchpad.net/~kicad-developers >>> More help : https://help.launchpad.net/ListHelp > > > _______________________________________________ > Mailing list: https://launchpad.net/~kicad-developers > Post to : kicad-developers@xxxxxxxxxxxxxxxxxxx > Unsubscribe : https://launchpad.net/~kicad-developers > More help : https://help.launchpad.net/ListHelp
Attachment:
0004-Dialog-changes-to-go-with-new-menu-structure.patch
Description: Binary data
Attachment:
0005-Grid-dialog-changes-to-go-along-with-menu-changes.patch
Description: Binary data
| Thread Previous • Date Previous • Date Next • Thread Next |
