kicad-developers team mailing list archive
-
kicad-developers team
-
Mailing list archive
-
Message #34119
Re: wxPython/wxWidgets compatibility check
But I notice it is broken on the macos nightly.
It can not import the wx python module and hence we get an empty string for
the toolkit from wxpython, (osx_cocoa vs ).
http://ci.kicad-pcb.org/job/osx-kicad-adam-head/576/console
2018-02-20 23:55 GMT+01:00 Nick Østergaard <oe.nick@xxxxxxxxx>:
> Yippee, build fixed!
> Project KiCad (Windows, MSYS2) Nightly Build build #203: FIXED in 30 min:
> http://darine.hogyros.de:8080/job/windows-kicad-msys2/203/
>
> 2018-02-20 20:33 GMT+01:00 Maciej Suminski <maciej.suminski@xxxxxxx>:
>
>> Apologies, it should be fine now.
>>
>> Cheers,
>> Orson
>>
>> On 02/20/2018 08:09 PM, Wayne Stambaugh wrote:
>> > Me too! Orson, can you please take a look at this when you get a
>> chance.
>> >
>> > On 2/20/2018 12:10 PM, Nick Østergaard wrote:
>> >> Ok, but it seems to break the msys2 build.
>> >>
>> >> http://darine.hogyros.de:8080/job/windows-kicad-msys2/202/console
>> >>
>> >> *17:58:19* C:/msys64/mingw32/lib/python2.
>> 7/site-packages/wx-3.0-msw/wx/_core.py:16633: UserWarning:
>> wxPython/wxWidgets release number mismatch
>> >> *17:58:19* warnings.warn("wxPython/wxWidgets release number
>> mismatch")
>> >> *17:58:19* CMake Error at CMakeLists.txt:710 (message):
>> >> *17:58:19*
>> >> *17:58:19*
>> >> *17:58:19* wxWidgets and wxPython use different toolkits ( vs msw).
>> It will result in
>> >> *17:58:19* a broken build. Please either install wxPython built
>> using or add
>> >> *17:58:19* '-DKICAD_SCRIPTING_WXPYTHON=OFF' to cmake parameters to
>> disable wxPython
>> >> *17:58:19* support.
>> >>
>> >>
>> >> Latest wxpython classic is 3.0.2.0 and the wxwidgets is 3.0.3.
>> >>
>> >> 2018-02-20 17:52 GMT+01:00 Maciej Sumiński <maciej.suminski@xxxxxxx
>> >> <mailto:maciej.suminski@xxxxxxx>>:
>> >>
>> >> Ok, committed with a message explaining the possible solutions.
>> >>
>> >> Cheers,
>> >> Orson
>> >>
>> >> On 02/20/2018 03:22 PM, Wayne Stambaugh wrote:
>> >> > Orson,
>> >> >
>> >> > You should just be able to turn of the wxPython scripting. All
>> of the
>> >> > other scripting should work fine unless someone changed
>> something that
>> >> > drags in wxPython when only the KICAD_SCRIPTING option is
>> enabled.
>> >> >
>> >> > Cheers,
>> >> >
>> >> > Wayne
>> >> >
>> >> > On 2/20/2018 2:40 AM, Maciej Sumiński wrote:
>> >> >> Hi Nick,
>> >> >>
>> >> >> Thank you for testing the patch. I think a hint about disabling
>> >> >> scripting is a good idea. Do you know if it is enough just to
>> disable
>> >> >> wxPython or rather everything scripting related should be
>> turned off?
>> >> >>
>> >> >> There is a different warning when GTK3 is detected as the
>> >> wxWidgets toolkit.
>> >> >>
>> >> >> Regards,
>> >> >> Orson
>> >> >>
>> >> >> On 02/19/2018 10:47 PM, Nick Østergaard wrote:
>> >> >>> Ok, I just tried to do:
>> >> >>>
>> >> >>> In [3]: wx.version()
>> >> >>> Out[3]: '4.0.1 gtk3 (phoenix)'
>> >> >>>
>> >> >>> I clearly also have python2-wxpython-phoenix installed. I just
>> >> tried to
>> >> >>> remove that from my system.
>> >> >>>
>> >> >>> Now it seems to complete the cmake configure successfully. I
>> >> guess the
>> >> >>> patch works afterall :D
>> >> >>>
>> >> >>> But I have a comment. Should we be a bit more helpful for the
>> >> packager, to
>> >> >>> tell him that he can temporarely disable the scripting options
>> >> to make it
>> >> >>> build, maybe also hint that we on do support gtk2 for the time
>> >> being.
>> >> >>>
>> >> >>> 2018-02-19 22:28 GMT+01:00 Nick Østergaard <oe.nick@xxxxxxxxx
>> >> <mailto:oe.nick@xxxxxxxxx>>:
>> >> >>>
>> >> >>>> Hello Maciej,
>> >> >>>>
>> >> >>>> I just tested your patch on archlinux. It does not seem to
>> work
>> >> properly,
>> >> >>>> tested in a clean build dir. Even if I remove wxpython (with
>> >> gtk3) and
>> >> >>>> install wxpython-gtk2 (with gtk2 from AUR) it still complains
>> >> that there is
>> >> >>>> a mismatch. I have wxwidgets with gtk2 and gtk3 installed,
>> taht
>> >> is the
>> >> >>>> packages wxgtk2 and wxgtk3.
>> >> >>>>
>> >> >>>> I see it says; "wxPython version 3.0 found."
>> >> >>>>
>> >> >>>> So the patch as is seems to be broken for me.
>> >> >>>>
>> >> >>>> 2018-02-17 21:03 GMT+01:00 Maciej Suminski
>> >> <maciej.suminski@xxxxxxx <mailto:maciej.suminski@xxxxxxx>>:
>> >> >>>>
>> >> >>>>> In order to prevent faulty builds in case of
>> >> wxPython/wxWidgets toolkit
>> >> >>>>> mismatch [1,2] (gtk2 vs gtk3), I added a check in CMakeLists.
>> >> I verified
>> >> >>>>> it with Windows 7 and Linux, but I would love to hear from
>> OSX
>> >> users
>> >> >>>>> that I do not break their build.
>> >> >>>>>
>> >> >>>>> Cheers,
>> >> >>>>> Orson
>> >> >>>>>
>> >> >>>>> 1. https://forum.kicad.info/t/9493
>> >> <https://forum.kicad.info/t/9493>
>> >> >>>>> 2. https://bugs.launchpad.net/kicad/+bug/1746753
>> >> <https://bugs.launchpad.net/kicad/+bug/1746753>
>> >> >>>>>
>> >> >>>>> _______________________________________________
>> >> >>>>> Mailing list: https://launchpad.net/~kicad-developers
>> >> <https://launchpad.net/~kicad-developers>
>> >> >>>>> Post to : kicad-developers@xxxxxxxxxxxxxxxxxxx
>> >> <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
>> >> >>>>> Unsubscribe : https://launchpad.net/~kicad-developers
>> >> <https://launchpad.net/~kicad-developers>
>> >> >>>>> More help : https://help.launchpad.net/ListHelp
>> >> <https://help.launchpad.net/ListHelp>
>> >> >>>>>
>> >> >>>>>
>> >> >>>>
>> >> >>>
>> >> >>
>> >> >>
>> >> >>
>> >> >>
>> >> >> _______________________________________________
>> >> >> Mailing list: https://launchpad.net/~kicad-developers
>> >> <https://launchpad.net/~kicad-developers>
>> >> >> Post to : kicad-developers@xxxxxxxxxxxxxxxxxxx
>> >> <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
>> >> >> Unsubscribe : https://launchpad.net/~kicad-developers
>> >> <https://launchpad.net/~kicad-developers>
>> >> >> More help : https://help.launchpad.net/ListHelp
>> >> <https://help.launchpad.net/ListHelp>
>> >> >>
>> >> >
>> >> > _______________________________________________
>> >> > Mailing list: https://launchpad.net/~kicad-developers
>> >> <https://launchpad.net/~kicad-developers>
>> >> > Post to : kicad-developers@xxxxxxxxxxxxxxxxxxx
>> >> <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
>> >> > Unsubscribe : https://launchpad.net/~kicad-developers
>> >> <https://launchpad.net/~kicad-developers>
>> >> > More help : https://help.launchpad.net/ListHelp
>> >> <https://help.launchpad.net/ListHelp>
>> >> >
>> >>
>> >>
>> >>
>> >> _______________________________________________
>> >> Mailing list: https://launchpad.net/~kicad-developers
>> >> <https://launchpad.net/~kicad-developers>
>> >> Post to : kicad-developers@xxxxxxxxxxxxxxxxxxx
>> >> <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
>> >> Unsubscribe : https://launchpad.net/~kicad-developers
>> >> <https://launchpad.net/~kicad-developers>
>> >> More help : https://help.launchpad.net/ListHelp
>> >> <https://help.launchpad.net/ListHelp>
>> >>
>> >>
>> >>
>> >>
>> >> _______________________________________________
>> >> Mailing list: https://launchpad.net/~kicad-developers
>> >> Post to : kicad-developers@xxxxxxxxxxxxxxxxxxx
>> >> Unsubscribe : https://launchpad.net/~kicad-developers
>> >> More help : https://help.launchpad.net/ListHelp
>> >>
>> >
>> > _______________________________________________
>> > Mailing list: https://launchpad.net/~kicad-developers
>> > Post to : kicad-developers@xxxxxxxxxxxxxxxxxxx
>> > Unsubscribe : https://launchpad.net/~kicad-developers
>> > More help : https://help.launchpad.net/ListHelp
>> >
>>
>> _______________________________________________
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to : kicad-developers@xxxxxxxxxxxxxxxxxxx
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help : https://help.launchpad.net/ListHelp
>>
>
>
Follow ups
References
-
wxPython/wxWidgets compatibility check
From: Maciej Suminski, 2018-02-17
-
Re: wxPython/wxWidgets compatibility check
From: Nick Østergaard, 2018-02-19
-
Re: wxPython/wxWidgets compatibility check
From: Nick Østergaard, 2018-02-19
-
Re: wxPython/wxWidgets compatibility check
From: Maciej Sumiński, 2018-02-20
-
Re: wxPython/wxWidgets compatibility check
From: Wayne Stambaugh, 2018-02-20
-
Re: wxPython/wxWidgets compatibility check
From: Maciej Sumiński, 2018-02-20
-
Re: wxPython/wxWidgets compatibility check
From: Nick Østergaard, 2018-02-20
-
Re: wxPython/wxWidgets compatibility check
From: Wayne Stambaugh, 2018-02-20
-
Re: wxPython/wxWidgets compatibility check
From: Maciej Suminski, 2018-02-20
-
Re: wxPython/wxWidgets compatibility check
From: Nick Østergaard, 2018-02-20