← Back to team overview

kicad-developers team mailing list archive

Re: [PATCH] Pcbnew menu bar

 

I can’t tell, I didn’t look for that bug.
I didn’t follow the restructuring on the ML.
My comment was just about the “Preferences” menu entry in KiCad menu.
I did search it for some time before the restructuring and wondered a bit that it still like that after.

> On 21. Feb 2018, at 19:13, Michael Kavanagh <michael@xxxxxxxxxxxxxxxxxx> wrote:
> 
> Bernhard, do you mean this bug [1] existed before the 3b085f0 "Pcbnew new menubar structure" commit?
> 
> [1] https://bugs.launchpad.net/kicad/+bug/1750494 <https://bugs.launchpad.net/kicad/+bug/1750494>
> 
> On 21 February 2018 at 13:07, Bernhard Stegmaier <stegmaier@xxxxxxxxxxxxx <mailto:stegmaier@xxxxxxxxxxxxx>> wrote:
> > Hi,
> >
> > Just to mention… it has been like this before the patches.
> > At least on macOS, there is still a “Preferences” menu entry below the
> > “KiCad” menu bar entry (the “General Settings” dialog).
> > Then, there is the “Preferences” menu… without those “General Setting”.
> >
> > Because there is a “Preferences” menu bar entry I didn’t look anywhere else
> > for the general settings.
> > Took me quite a while to find them in the “KiCad” menu bar entry.
> >
> > Any plans to change this?
> >
> >
> > Regards,
> > Bernhard
> >
> > On 20. Feb 2018, at 08:17, Nick Østergaard <oe.nick@xxxxxxxxx <mailto:oe.nick@xxxxxxxxx>> wrote:
> >
> > Hello Michael and Jeff,
> >
> > It seems like we got our first small regression from this patch series.
> > Could you have a look. Please note it looks like it is window manager
> > dependent.
> > https://bugs.launchpad.net/kicad/+bug/1750494 <https://bugs.launchpad.net/kicad/+bug/1750494>
> >
> > Nick
> >
> > 2018-02-18 23:03 GMT+01:00 Wayne Stambaugh <stambaughw@xxxxxxxxx <mailto:stambaughw@xxxxxxxxx>>:
> >>
> >> Indeed I did forget.  Thanks for the reminder.  Thank you Jeff for the
> >> patches.
> >>
> >>
> >> On 02/18/2018 03:02 PM, Michael Kavanagh wrote:
> >>>
> >>> Thanks Wayne. Please don't forget to merge Jeffs dialog changes which
> >>> complete the Pcbnew menubar modifications. I have reattached them to
> >>> this email for convenience.
> >>>
> >>> Cheers,
> >>> Michael
> >>>
> >>> On 18 February 2018 at 19:16, Wayne Stambaugh <stambaughw@xxxxxxxxx <mailto:stambaughw@xxxxxxxxx>>
> >>> wrote:
> >>>>
> >>>> Michael,
> >>>>
> >>>> I figured out why we are not using IS_ACCELERATOR for these menu
> >>>> entries.
> >>>> AddHotkeyName() adds a "+Alt+" to the hotkey so this is *not* what we
> >>>> want
> >>>> so I used the original 0003 patch.  I apologize for the confusion.  I
> >>>> merged
> >>>> this and you 0004 patch.  We can make any tweaks to it if it's not
> >>>> exactly
> >>>> what we want.  Thank you for your contribution to KiCad.
> >>>>
> >>>> Cheers,
> >>>>
> >>>> Wayne
> >>>>
> >>>>
> >>>> On 02/18/2018 10:10 AM, Michael Kavanagh wrote:
> >>>>>
> >>>>>
> >>>>> In every other app New, Open, Save, Save As and Print are standard
> >>>>> hotkeys and not accelerators. They don't have the modifier key, so are
> >>>>> the "standard" keyboard shortcuts.
> >>>>>
> >>>>> Nevertheless, please find attached new patches for review. These
> >>>>> accompany both of Jeffs dialog patches. Hopefully I didn't break
> >>>>> anything, implementing the sketch modes removed from the dialogs
> >>>>> involved fiddling with the GAL tools framework.
> >>>>>
> >>>>> Cheers,
> >>>>> Michael
> >>>>>
> >>>>> On 17 February 2018 at 17:27, Wayne Stambaugh <stambaughw@xxxxxxxxx <mailto:stambaughw@xxxxxxxxx>>
> >>>>> wrote:
> >>>>>>
> >>>>>>
> >>>>>> It should be.  We really need to get out of the bad habit of having
> >>>>>> toolbar only access to tools and settings.  I'm sure there are some in
> >>>>>> the schematic editor, symbol editor, and footprint editor as well.
> >>>>>>
> >>>>>> On 02/17/2018 06:16 AM, Jeff Young wrote:
> >>>>>>>
> >>>>>>>
> >>>>>>> The Fill/Outline stuff is included.  Not sure about High Contrast
> >>>>>>> mode,
> >>>>>>> but it probably should be.
> >>>>>>>
> >>>>>>>> On 17 Feb 2018, at 06:58, Gaurav Juvekar <gauravjuvekar@xxxxxxxxx <mailto:gauravjuvekar@xxxxxxxxx>>
> >>>>>>>> wrote:
> >>>>>>>>
> >>>>>>>> Hi all,
> >>>>>>>>
> >>>>>>>> Probably not too relevant, but can we have a workaround of
> >>>>>>>> https://bugs.launchpad.net/kicad/+bug/1575097 <https://bugs.launchpad.net/kicad/+bug/1575097> (hidden icons) by
> >>>>>>>> adding
> >>>>>>>> View -> High Contrast (Checkable like the "Flip board view")
> >>>>>>>> View -> Tracks -> Outline (Radio button like the canvas selector)
> >>>>>>>>                 -> Fill
> >>>>>>>> View -> Vias   -> Outline
> >>>>>>>>                 -> Fill
> >>>>>>>> View -> Pads   -> Outline
> >>>>>>>>                 -> Fill
> >>>>>>>>
> >>>>>>>> to the menu entries?
> >>>>>>>>
> >>>>>>>> --
> >>>>>>>> Regards,
> >>>>>>>> Gaurav Juvekar
> >>>>>>>>
> >>>>>>>> _______________________________________________
> >>>>>>>> Mailing list: https://launchpad.net/~kicad-developers <https://launchpad.net/~kicad-developers>
> >>>>>>>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
> >>>>>>>> Unsubscribe : https://launchpad.net/~kicad-developers <https://launchpad.net/~kicad-developers>
> >>>>>>>> More help   : https://help.launchpad.net/ListHelp <https://help.launchpad.net/ListHelp>
> >>>>>>>
> >>>>>>>
> >>>>>>>
> >>>>>>>
> >>>>>>> _______________________________________________
> >>>>>>> Mailing list: https://launchpad.net/~kicad-developers <https://launchpad.net/~kicad-developers>
> >>>>>>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
> >>>>>>> Unsubscribe : https://launchpad.net/~kicad-developers <https://launchpad.net/~kicad-developers>
> >>>>>>> More help   : https://help.launchpad.net/ListHelp <https://help.launchpad.net/ListHelp>
> >>>>>>>
> >>>>>>
> >>>>>> _______________________________________________
> >>>>>> Mailing list: https://launchpad.net/~kicad-developers <https://launchpad.net/~kicad-developers>
> >>>>>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
> >>>>>> Unsubscribe : https://launchpad.net/~kicad-developers <https://launchpad.net/~kicad-developers>
> >>>>>> More help   : https://help.launchpad.net/ListHelp <https://help.launchpad.net/ListHelp>
> >>>>>>
> >>>>>>
> >>>>>> _______________________________________________
> >>>>>> Mailing list: https://launchpad.net/~kicad-developers <https://launchpad.net/~kicad-developers>
> >>>>>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
> >>>>>> Unsubscribe : https://launchpad.net/~kicad-developers <https://launchpad.net/~kicad-developers>
> >>>>>> More help   : https://help.launchpad.net/ListHelp <https://help.launchpad.net/ListHelp>
> >>>>
> >>>>
> >>>>
> >>>> _______________________________________________
> >>>> Mailing list: https://launchpad.net/~kicad-developers <https://launchpad.net/~kicad-developers>
> >>>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
> >>>> Unsubscribe : https://launchpad.net/~kicad-developers <https://launchpad.net/~kicad-developers>
> >>>> More help   : https://help.launchpad.net/ListHelp <https://help.launchpad.net/ListHelp>
> >>>>
> >>>>
> >>>> _______________________________________________
> >>>> Mailing list: https://launchpad.net/~kicad-developers <https://launchpad.net/~kicad-developers>
> >>>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
> >>>> Unsubscribe : https://launchpad.net/~kicad-developers <https://launchpad.net/~kicad-developers>
> >>>> More help   : https://help.launchpad.net/ListHelp <https://help.launchpad.net/ListHelp>
> >>
> >>
> >> _______________________________________________
> >> Mailing list: https://launchpad.net/~kicad-developers <https://launchpad.net/~kicad-developers>
> >> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
> >> Unsubscribe : https://launchpad.net/~kicad-developers <https://launchpad.net/~kicad-developers>
> >> More help   : https://help.launchpad.net/ListHelp <https://help.launchpad.net/ListHelp>
> >
> >
> > _______________________________________________
> > Mailing list: https://launchpad.net/~kicad-developers <https://launchpad.net/~kicad-developers>
> > Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
> > Unsubscribe : https://launchpad.net/~kicad-developers <https://launchpad.net/~kicad-developers>
> > More help   : https://help.launchpad.net/ListHelp <https://help.launchpad.net/ListHelp>
> >
> >
> >
> > _______________________________________________
> > Mailing list: https://launchpad.net/~kicad-developers <https://launchpad.net/~kicad-developers>
> > Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
> > Unsubscribe : https://launchpad.net/~kicad-developers <https://launchpad.net/~kicad-developers>
> > More help   : https://help.launchpad.net/ListHelp <https://help.launchpad.net/ListHelp>
> >
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp


References