← Back to team overview

kicad-developers team mailing list archive

Re: [PATCH] Rearrange Render panel of PcbNew layer widget; add spacers

 

Hi JP, good catch, the attached fixes it for me

-Jon

On Fri, Feb 23, 2018 at 7:18 AM, jp charras <jp.charras@xxxxxxxxxx> wrote:

> Le 23/02/2018 à 01:04, Jon Evans a écrit :
> > Here are two more quick patches addressing some of the easier changes.
> > I have some other bugs to look at that seem more urgent, so I'm not
> going to work on the right-click
> > menu or settings persistence.
> >
> > Thanks,
> > Jon
> >
>
> Hi Jon,
>
> There is a (minor but annoying) issue about patch:
>
> "Only show microvia and blind/buried via settings if they are enabled"
>
> When I load a board that have microvia and blind/buried vias allowed, the
> layer manager does not
> show the microvia and blind/buried vias menuitems.
>
> They are displayed only after opening and closing by OK button the Design
> Rules menu.
>
> (Tested on W7/32bits)
>
> --
> Jean-Pierre CHARRAS
>
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>
From d659420969f56036c7ab15464f99f5d864f7d7e3 Mon Sep 17 00:00:00 2001
From: Jon Evans <jon@xxxxxxxxxxxxx>
Date: Fri, 23 Feb 2018 08:25:01 -0500
Subject: [PATCH] Fix display of via settings on initial board load

---
 pcbnew/pcb_edit_frame.cpp | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/pcbnew/pcb_edit_frame.cpp b/pcbnew/pcb_edit_frame.cpp
index dd3c79398..132044127 100644
--- a/pcbnew/pcb_edit_frame.cpp
+++ b/pcbnew/pcb_edit_frame.cpp
@@ -556,6 +556,10 @@ void PCB_EDIT_FRAME::SetBoard( BOARD* aBoard )
         // reload the worksheet
         SetPageSettings( aBoard->GetPageSettings() );
     }
+
+    // Refill items list after design rules loaded
+    if( m_Layers )
+        m_Layers->ReFillRender();
 }
 
 
-- 
2.14.1


Follow ups

References