← Back to team overview

kicad-developers team mailing list archive

Re: Fabrication Outputs and Plot

 

Thanks for your replies. I think there's a consensus that this needs
improving and restructuring, but given your emails, it sounds like a big
task :)

In the meantime, would you accept the attached patch to change the order in
which "Fabrication Outputs" is listed in the menu?

Before:
Fabrication Outputs
Import
Export

After:
Import
Export
Fabrication Outputs


I think that "Fabrication Outputs" is conceptually very similar to "Export"
and it belongs next to it better than having "Import" in between them.

Thanks,
Diego



On Sat, Feb 24, 2018 at 9:01 PM, Wayne Stambaugh <stambaughw@xxxxxxxxx>
wrote:

> I'm open to any solution that improves the current situation.  This
> solution seems reasonable as well.  I also just noticed that wx 3.1.1 was
> just released and it looks like there have been a lot of fixes the various
> device contexts so some of the work may have already been done for us.
>
> On 02/24/2018 03:31 PM, Jon Evans wrote:
>
>> I thought the idea was to write a backend for GAL that could render onto
>> a wxDC for printing?  It seems wise to use the wxWidgets printing API
>> rather than bypassing it; so we just need to be able to render onto a DC
>> (without using the old XOR tricks from the legacy drawing code)
>>
>> On Sat, Feb 24, 2018 at 3:26 PM, Jeff Young <jeff@xxxxxxxxx <mailto:
>> jeff@xxxxxxxxx>> wrote:
>>
>>     On the other hand, if we don’t then we have to keep carrying around
>>     a boat-load of Legacy rendering code (because we use that for
>> printing).
>>
>>      > On 24 Feb 2018, at 20:16, Wayne Stambaugh <stambaughw@xxxxxxxxx
>>     <mailto:stambaughw@xxxxxxxxx>> wrote:
>>      >
>>      > There is no plan yet but it has been discussed.  The only
>>     downside is that we will have to write our own print handling on
>>     windows and I'm guessing macos.  That's one of the reasons no one
>>     has signed up yet because it will be a large undertaking.
>>      >
>>      > On 02/24/2018 02:02 PM, Jon Evans wrote:
>>      >> Yes I think that's the plan, just needs someone to sign up to
>>     write it :)
>>      >> On Sat, Feb 24, 2018, 14:00 Andrzej Wolski
>>     <awolski.kicad@xxxxxxxxx <mailto:awolski.kicad@xxxxxxxxx>
>>     <mailto:awolski.kicad@xxxxxxxxx <mailto:awolski.kicad@xxxxxxxxx>>>
>>     wrote:
>>      >>    Cairo have PDF, SVG and Postscript support. I was once
>>     wondering if
>>      >>    GAL/Cairo could be used for printing.
>>      >>    Andrzej
>>      >>    W dniu 2018-02-24 o 19:24, Jon Evans pisze:
>>      >>>    Yeah, there (at least) three different dialogs that all
>> present
>>      >>>    similar things (i.e. a list of layers to include, settings,
>>     etc):
>>      >>>
>>      >>>    Export->SVG
>>      >>>    Print
>>      >>>    Plot
>>      >>>
>>      >>>    The Print code for Export->SVG seems to just use the same SVG
>>      >>>    plotter, so maybe it's just mostly GUI cleanup that is needed.
>>      >>>
>>      >>>    The main Print code does need an overhaul to use something
>> other
>>      >>>    than wxDC for graphics generation (and perhaps adding some
>> more
>>      >>>    features to PDF export)
>>      >>>
>>      >>>    -Jon
>>      >>>
>>      >>>    On Sat, Feb 24, 2018 at 1:16 PM, Jeff Young <jeff@xxxxxxxxx
>>     <mailto:jeff@xxxxxxxxx>
>>      >>>    <mailto:jeff@xxxxxxxxx <mailto:jeff@xxxxxxxxx>>> wrote:
>>      >>>
>>      >>>        Plot SVG and Export SVG are different.  The former goes
>>      >>>        through the Plot code while the later goes through the
>> Print
>>      >>>        code.
>>      >>>
>>      >>>        Do we need both?  I haven’t a clue.
>>      >>>
>>      >>>        It would be nice to clean this stuff up, if there is in
>>     fact a
>>      >>>        clean way to present it.
>>      >>>
>>      >>>        Cheers,
>>      >>>        Jeff.
>>      >>>
>>      >>>
>>      >>>>        On 24 Feb 2018, at 14:54, Jon Evans <jon@xxxxxxxxxxxxx
>>     <mailto:jon@xxxxxxxxxxxxx>
>>      >>>>        <mailto:jon@xxxxxxxxxxxxx <mailto:jon@xxxxxxxxxxxxx>>>
>>     wrote:
>>      >>>>
>>      >>>>        I agree with this! It has always tripped me up when I
>>     switch
>>      >>>>        back and forth between kicad and other EDA tools.
>>      >>>>
>>      >>>>        On Feb 24, 2018 9:31 AM, "Diego Herranz"
>>      >>>>        <diegoherranz@xxxxxxxxxxxxxxxx
>>     <mailto:diegoherranz@xxxxxxxxxxxxxxxx>
>>      >>>>        <mailto:diegoherranz@xxxxxxxxxxxxxxxx
>>
>>     <mailto:diegoherranz@xxxxxxxxxxxxxxxx>>> wrote:
>>      >>>>
>>      >>>>            Hi,
>>      >>>>
>>      >>>>            Now that so much work is happening on re-structuring
>>      >>>>            menus, I've remembered something I have always found
>>      >>>>            weird on pcbnew.
>>      >>>>
>>      >>>>            "Plot", from wihch you can obtain Gerbers is not
>> inside
>>      >>>>            "Fabrication Outputs", but on its own.
>>      >>>>            I find it weird to have the drill option inside
>>      >>>>            "Fabrication Outputs" but not the Gerbers (they are
>>      >>>>            normally needed together and in fact, you can go to
>>      >>>>            "Drill" from "Plot").
>>      >>>>
>>      >>>>            If "Plot" was Gerber only, I would recommend moving
>> it
>>      >>>>            inside "Fabrication Outputs" straight away but
>>     because it
>>      >>>>            also exports other formats, it's not so
>>     straightforward.
>>      >>>>
>>      >>>>            I think ideally we would have:
>>      >>>>
>>      >>>>            - Fabrication outputs
>>      >>>>              - Gerber...
>>      >>>>              - Drill
>>      >>>>              - ...
>>      >>>>            - Export
>>      >>>>              - STEP
>>      >>>>              - PDF...
>>      >>>>              - Postcript...
>>      >>>>              - DXF...
>>      >>>>              - ...
>>      >>>>
>>      >>>>            And I have just noticed SVG can be obtained from
>> "Plot"
>>      >>>>            or the "Export" submenu. Is it the same?
>>      >>>>
>>      >>>>            What do you guys think? I'm not necessarily
>> suggesting
>>      >>>>            looking into this before KiCad 5, just wanted to have
>>      >>>>            your view.
>>      >>>>
>>      >>>>            Thanks,
>>      >>>>            Diego
>>      >>>>
>>      >>>>
>>      >>>>            _______________________________________________
>>      >>>>            Mailing list:
>>     https://launchpad.net/~kicad-developers
>>     <https://launchpad.net/~kicad-developers>
>>      >>>>            <https://launchpad.net/%7Ekicad-developers
>>     <https://launchpad.net/%7Ekicad-developers>>
>>      >>>>            Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>>     <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
>>      >>>>            <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx
>>     <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>>
>>      >>>>            Unsubscribe :
>>     https://launchpad.net/~kicad-developers
>>     <https://launchpad.net/~kicad-developers>
>>      >>>>            <https://launchpad.net/%7Ekicad-developers
>>     <https://launchpad.net/%7Ekicad-developers>>
>>      >>>>            More help   : https://help.launchpad.net/ListHelp
>>     <https://help.launchpad.net/ListHelp>
>>      >>>>
>>      >>>>        _______________________________________________
>>      >>>>        Mailing list: https://launchpad.net/~kicad-developers
>>     <https://launchpad.net/~kicad-developers>
>>      >>>>        <https://launchpad.net/%7Ekicad-developers
>>     <https://launchpad.net/%7Ekicad-developers>>
>>      >>>>        Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>>     <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
>>      >>>>        <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx
>>     <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>>
>>      >>>>        Unsubscribe : https://launchpad.net/~kicad-developers
>>     <https://launchpad.net/~kicad-developers>
>>      >>>>        <https://launchpad.net/%7Ekicad-developers
>>     <https://launchpad.net/%7Ekicad-developers>>
>>      >>>>        More help   : https://help.launchpad.net/ListHelp
>>     <https://help.launchpad.net/ListHelp>
>>      >>>
>>      >>>
>>      >>>
>>      >>>
>>      >>>    _______________________________________________
>>      >>>    Mailing list:https://launchpad.net/~kicad-developers
>>     <https://launchpad.net/~kicad-developers>
>>      >>>    Post to     :kicad-developers@xxxxxxxxxxxxxxxxxxx
>>     <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
>>      >>>    <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx
>>     <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>>
>>      >>>    Unsubscribe :https://launchpad.net/~kicad-developers
>>     <https://launchpad.net/~kicad-developers>
>>      >>>    More help   :https://help.launchpad.net/ListHelp
>>     <https://help.launchpad.net/ListHelp>
>>      >>    _______________________________________________
>>      >>    Mailing list: https://launchpad.net/~kicad-developers
>>     <https://launchpad.net/~kicad-developers>
>>      >>    Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>>     <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
>>      >>    <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx
>>     <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>>
>>      >>    Unsubscribe : https://launchpad.net/~kicad-developers
>>     <https://launchpad.net/~kicad-developers>
>>      >>    More help   : https://help.launchpad.net/ListHelp
>>     <https://help.launchpad.net/ListHelp>
>>      >> _______________________________________________
>>      >> Mailing list: https://launchpad.net/~kicad-developers
>>     <https://launchpad.net/~kicad-developers>
>>      >> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>>     <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
>>      >> Unsubscribe : https://launchpad.net/~kicad-developers
>>     <https://launchpad.net/~kicad-developers>
>>      >> More help   : https://help.launchpad.net/ListHelp
>>     <https://help.launchpad.net/ListHelp>
>>      >
>>      > _______________________________________________
>>      > Mailing list: https://launchpad.net/~kicad-developers
>>     <https://launchpad.net/~kicad-developers>
>>      > Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>>     <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
>>      > Unsubscribe : https://launchpad.net/~kicad-developers
>>     <https://launchpad.net/~kicad-developers>
>>      > More help   : https://help.launchpad.net/ListHelp
>>     <https://help.launchpad.net/ListHelp>
>>
>>
>>     _______________________________________________
>>     Mailing list: https://launchpad.net/~kicad-developers
>>     <https://launchpad.net/~kicad-developers>
>>     Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>>     <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
>>     Unsubscribe : https://launchpad.net/~kicad-developers
>>     <https://launchpad.net/~kicad-developers>
>>     More help   : https://help.launchpad.net/ListHelp
>>     <https://help.launchpad.net/ListHelp>
>>
>>
>>
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>
From ea6de832aa1a870cf0f1fcf7c6d67501d2b02ecc Mon Sep 17 00:00:00 2001
From: Diego Herranz <diegoherranz@xxxxxxxxxxxxxxxx>
Date: Sun, 25 Feb 2018 19:09:53 +0000
Subject: [PATCH] pcbnew: reorder "Fabrication Outputs" in menu

Place it next to "Export" since it is similar conceptually
(it effectively exports to a few different formats too).
---
 pcbnew/menubar_pcb_editor.cpp | 53 ++++++++++++++++++++++---------------------
 1 file changed, 27 insertions(+), 26 deletions(-)

diff --git a/pcbnew/menubar_pcb_editor.cpp b/pcbnew/menubar_pcb_editor.cpp
index 2bdc626..4c97040 100644
--- a/pcbnew/menubar_pcb_editor.cpp
+++ b/pcbnew/menubar_pcb_editor.cpp
@@ -880,6 +880,33 @@ void prepareFilesMenu( wxMenu* aParentMenu, bool aIsOutsideProject )
 
     aParentMenu->AppendSeparator();
 
+    //----- Import submenu ------------------------------------------------------
+    wxMenu* submenuImport = new wxMenu();
+
+    AddMenuItem( submenuImport, ID_GEN_IMPORT_SPECCTRA_SESSION,
+                 _( "&Specctra Session..." ),
+                 _( "Import routed \"Specctra Session\" (*.ses) file" ),
+                 KiBitmap( import_xpm ) );
+
+    AddMenuItem( submenuImport, ID_GEN_IMPORT_DXF_FILE,
+                 _( "&DXF File..." ),
+                 _( "Import 2D Drawing DXF file to Pcbnew on Drawings layer" ),
+                 KiBitmap( import_xpm ) );
+
+    AddMenuItem( aParentMenu, submenuImport,
+                 ID_GEN_IMPORT_FILE, _( "&Import" ),
+                 _( "Import files" ), KiBitmap( import_xpm ) );
+
+
+    //----- Export submenu ------------------------------------------------------
+    wxMenu* submenuexport = new wxMenu();
+    prepareExportMenu( submenuexport );
+
+    AddMenuItem( aParentMenu, submenuexport,
+                 ID_GEN_EXPORT_FILE, _( "E&xport" ),
+                 _( "Export board" ), KiBitmap( export_xpm ) );
+
+
     //----- Fabrication Outputs submenu -----------------------------------------
     wxMenu* fabricationOutputsMenu = new wxMenu;
     AddMenuItem( fabricationOutputsMenu, ID_PCB_GEN_POS_MODULES_FILE,
@@ -912,32 +939,6 @@ void prepareFilesMenu( wxMenu* aParentMenu, bool aIsOutsideProject )
                  _( "Generate files for fabrication" ),
                  KiBitmap( fabrication_xpm ) );
 
-    //----- Import submenu ------------------------------------------------------
-    wxMenu* submenuImport = new wxMenu();
-
-    AddMenuItem( submenuImport, ID_GEN_IMPORT_SPECCTRA_SESSION,
-                 _( "&Specctra Session..." ),
-                 _( "Import routed \"Specctra Session\" (*.ses) file" ),
-                 KiBitmap( import_xpm ) );
-
-    AddMenuItem( submenuImport, ID_GEN_IMPORT_DXF_FILE,
-                 _( "&DXF File..." ),
-                 _( "Import 2D Drawing DXF file to Pcbnew on Drawings layer" ),
-                 KiBitmap( import_xpm ) );
-
-    AddMenuItem( aParentMenu, submenuImport,
-                 ID_GEN_IMPORT_FILE, _( "&Import" ),
-                 _( "Import files" ), KiBitmap( import_xpm ) );
-
-
-    //----- Export submenu ------------------------------------------------------
-    wxMenu* submenuexport = new wxMenu();
-    prepareExportMenu( submenuexport );
-
-    AddMenuItem( aParentMenu, submenuexport,
-                 ID_GEN_EXPORT_FILE, _( "E&xport" ),
-                 _( "Export board" ), KiBitmap( export_xpm ) );
-
     aParentMenu->AppendSeparator();
 
     AddMenuItem( aParentMenu, ID_SHEET_SET,
-- 
2.7.4


Follow ups

References