kicad-developers team mailing list archive

[Jon Evans <jon@xxxxxxxxxxxxx>]

One more performance optimization attached

Clemens -- are you talking to me directly?  For most of my smaller fixes I
do not push them to anywhere public before they get merged.  Wayne has been
merging my changes pretty quickly though, so the nightly builds are pretty
close to real-time.

On Sun, Feb 25, 2018 at 6:49 PM, Clemens Koller <cko@xxxxxxxxx> wrote:

> What is the quickest way to git pull your changes when I want to follow
> you in real-time?
>
> git.launchpad.net/kicad ?
>
> On 2018-02-26 00:39, Wayne Stambaugh wrote:
> > Patches merged.  Thanks!
> >
> > On 02/25/2018 03:14 PM, Jon Evans wrote:
> >> These patches improves redraw performance when toggling sketch/filled
> >> draw modes.
> >>
> >> On Linux at least, the difference is quite noticeable on complicated
> >> Gerber files.
> >>
> >> -Jon
> >>
> >>
> >> _______________________________________________
> >> Mailing list: https://launchpad.net/~kicad-developers
> >> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> >> Unsubscribe : https://launchpad.net/~kicad-developers
> >> More help   : https://help.launchpad.net/ListHelp
> >>
> >
> > _______________________________________________
> > Mailing list: https://launchpad.net/~kicad-developers
> > Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> > Unsubscribe : https://launchpad.net/~kicad-developers
> > More help   : https://help.launchpad.net/ListHelp
> >
>
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>

From 5302d921722bae5725ceaae03c2e16cc0c1bbead Mon Sep 17 00:00:00 2001
From: Jon Evans <jon@xxxxxxxxxxxxx>
Date: Sun, 25 Feb 2018 18:55:18 -0500
Subject: [PATCH] Only update item color when highlighting items in GerbView

---
 gerbview/tools/gerbview_control.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gerbview/tools/gerbview_control.cpp b/gerbview/tools/gerbview_control.cpp
index f0d196165..9de8b8322 100644
--- a/gerbview/tools/gerbview_control.cpp
+++ b/gerbview/tools/gerbview_control.cpp
@@ -113,7 +113,7 @@ int GERBVIEW_CONTROL::HighlightControl( const TOOL_EVENT& aEvent )
         }
     }
 
-    m_frame->GetGalCanvas()->GetView()->RecacheAllItems();
+    m_frame->GetGalCanvas()->GetView()->UpdateAllItems( KIGFX::COLOR );
     m_frame->GetGalCanvas()->Refresh();
 
     return 0;
-- 
2.14.1