← Back to team overview

kicad-developers team mailing list archive

Re: [PATCH] Don't use the RTREE in UpdateAllLayersOrder() / UpdateAllLayersColor()

 

Hi Orson, I don't see that behavior, but I don't have asan turned on right
now either so maybe it isn't deterministic without it.

I won't be able to look at this issue until tonight, so please revert for
now unless you find a simple fix (I guess maybe preview items are missing
some initialization that permanent items get?)

Thanks,
-Jon

On Mon, Feb 26, 2018, 05:02 Maciej Sumiński <maciej.suminski@xxxxxxx> wrote:

> Jon,
>
> With this patch applied, any layer switching in pcbnew leads to a crash,
> even with no layout loaded. Can anyone else confirm this? See the the
> attached address sanitizer report for details.
>
> Regards,
> Orson
>
> On 02/25/2018 10:01 PM, Jon Evans wrote:
> > This patch uses simple iteration instead of the RTREE search to update
> the
> > layer order and color in VIEW.  On my Linux system, this results in a
> ~50%
> > speedup in release build (less in debug build) and is most noticeable
> when
> > switching layers in GerbView with large Gerber files loaded (i.e. high
> > number of items in the view).
> >
> > -Jon
> >
> >
> >
> > _______________________________________________
> > Mailing list: https://launchpad.net/~kicad-developers
> > Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> > Unsubscribe : https://launchpad.net/~kicad-developers
> > More help   : https://help.launchpad.net/ListHelp
> >
>
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>

References