← Back to team overview

kicad-developers team mailing list archive

Re: [PATCH] Don't use the RTREE in UpdateAllLayersOrder() / UpdateAllLayersColor()

 

Wayne,

I meant selecting any layer in the right-hand layer widget. Perhaps it
is a false positive in clang analyzer, I will have a look at it. Pcbnew
does not crash here when built with gcc (and no analyzer enabled).

Cheers,
Orson

On 02/26/2018 03:02 PM, Wayne Stambaugh wrote:
> Orson,
> 
> What do you mean by "any layer switching"?  I am not have any issues on
> windows when selecting a different layer in the layer manager using
> either canvas when launched from kicad or stand alone mode.
> 
> Cheers,
> 
> Wayne
> 
> On 2/26/2018 5:01 AM, Maciej Sumiński wrote:
>> Jon,
>>
>> With this patch applied, any layer switching in pcbnew leads to a crash,
>> even with no layout loaded. Can anyone else confirm this? See the the
>> attached address sanitizer report for details.
>>
>> Regards,
>> Orson
>>
>> On 02/25/2018 10:01 PM, Jon Evans wrote:
>>> This patch uses simple iteration instead of the RTREE search to update the
>>> layer order and color in VIEW.  On my Linux system, this results in a ~50%
>>> speedup in release build (less in debug build) and is most noticeable when
>>> switching layers in GerbView with large Gerber files loaded (i.e. high
>>> number of items in the view).
>>>
>>> -Jon
>>>
>>>
>>>
>>> _______________________________________________
>>> Mailing list: https://launchpad.net/~kicad-developers
>>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>>> Unsubscribe : https://launchpad.net/~kicad-developers
>>> More help   : https://help.launchpad.net/ListHelp
>>>
>>
>>
>>
>> _______________________________________________
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp
>>
> 
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
> 


Attachment: signature.asc
Description: OpenPGP digital signature


Follow ups

References