← Back to team overview

kicad-developers team mailing list archive

Re: [PATCH] Rework footprint selection filtering to improve behavior

 

Hi Andrzej,

This was my intention, which is why I said I was prepared for other people
to have other opinions :-)

I think that you should still be able to select footprints even if the
"front pads" is hidden from layers like the paste layer, *unless* you are
in high contrast mode.

-Jon

On Fri, Mar 2, 2018 at 3:53 AM, Andrzej Wolski <awolski.kicad@xxxxxxxxx>
wrote:

> I've tried this patch, and there is a small issue: if you have only eg
> front paste layer enabled and front pads are hidden, footprint is still
> selectable.
>
> Andrzej
>
>
> W dniu 2018-02-27 o 04:11, Jon Evans pisze:
>
> This patch changes the selection logic for footprints to fix a reported
> issue[1] and to make the behavior more logical to me.
>
> I know that correct selection behavior is something of a personal
> preference, so I'm ready to be flamed :-)
>
> The new behavior:
>
> A footprint may be selected if:
> 1) The corresponding "Footprints" switch is on in the Items tab, AND
> 2) One or more of the layers that the footprint draws on is visible
>
> This means that if all of the layers are turned off, footprints are not
> selectable (fixes the bug), but it also means that now footprints can be
> selected if any draw layers are visible (for example, if you have only
> F.Mask enabled, you can select a footprint that has solder mask and is on
> the front layer).
>
> Before anyone complains, this is only if high-contrast mode is turned
> OFF.  When it is on, you can still only select items that *only* exist on
> that layer (to make moving silkscreen around easier, for example)
>
> Even though this adds some more for-loops to selection filtering, I have
> not noticed any performance hits on some selection of large boards that I
> tested.  More testing is welcome.
>
> [1] https://bugs.launchpad.net/kicad/+bug/1751960
>
> -Jon
>
>
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>
>
>
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>
>

Follow ups

References