← Back to team overview

kicad-developers team mailing list archive

Re: [PATCH] Fix building on macOS with non-Xcode clang

 

I works for me (although I’m using more-or-less the same dev env as Bernhard so it’s not much of a second datapoint).

Cheers,
Jeff.


> On 4 Mar 2018, at 18:00, Wayne Stambaugh <stambaughw@xxxxxxxxx> wrote:
> 
> I didn't notice any issues on linux builds.  Has anyone else confirmed
> this doesn't break anything on macos builds?
> 
> On 03/04/2018 07:26 AM, Bernhard Stegmaier wrote:
>> Hi,
>> 
>> Attached patch fixes building on macOS with non-Xcode clang:
>> * To avoid problems make documentation suggest that cmake_minimum_required(...) has to be the very first statement directly followed by project(...)
>> * Policy CMP0025 must be set with min version <3.1 to NEW otherwise cmake will ignore CMAKE_CXX_STANDARD with non-Xcode clang
>> 
>> Tested on macOS with native and non-Xcode clang.
>> 
>> 
>> Regards,
>> Bernhard
>> 
>> 
>> 
>> 
>> _______________________________________________
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp
>> 
> 
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp



References