← Back to team overview

kicad-developers team mailing list archive

Re: [PATCH] Fix building on macOS with non-Xcode clang

 

Please note that the fix is only needed with a non-Xcode clang.
My cmake is 3.10.x, I had the problem both with clang-5.0.1 and clang-6.0 from MacPorts.
clang-6.0 only did work because it defaults to C++-14.

Xcode clang is fine without the change.


Bernhard

> On 4. Mar 2018, at 19:15, Seth Hillbrand <seth.hillbrand@xxxxxxxxx> wrote:
> 
> I see no issues on Mac OS.
> 
> -S
> 
> 
> 
> On Mar 4, 2018 10:00 AM, "Wayne Stambaugh" <stambaughw@xxxxxxxxx <mailto:stambaughw@xxxxxxxxx>> wrote:
> I didn't notice any issues on linux builds.  Has anyone else confirmed
> this doesn't break anything on macos builds?
> 
> On 03/04/2018 07:26 AM, Bernhard Stegmaier wrote:
> > Hi,
> >
> > Attached patch fixes building on macOS with non-Xcode clang:
> > * To avoid problems make documentation suggest that cmake_minimum_required(...) has to be the very first statement directly followed by project(...)
> > * Policy CMP0025 must be set with min version <3.1 to NEW otherwise cmake will ignore CMAKE_CXX_STANDARD with non-Xcode clang
> >
> > Tested on macOS with native and non-Xcode clang.
> >
> >
> > Regards,
> > Bernhard
> >
> >
> >
> >
> > _______________________________________________
> > Mailing list: https://launchpad.net/~kicad-developers <https://launchpad.net/~kicad-developers>
> > Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
> > Unsubscribe : https://launchpad.net/~kicad-developers <https://launchpad.net/~kicad-developers>
> > More help   : https://help.launchpad.net/ListHelp <https://help.launchpad.net/ListHelp>
> >
> 
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers <https://launchpad.net/~kicad-developers>
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
> Unsubscribe : https://launchpad.net/~kicad-developers <https://launchpad.net/~kicad-developers>
> More help   : https://help.launchpad.net/ListHelp <https://help.launchpad.net/ListHelp>
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp


References