← Back to team overview

kicad-developers team mailing list archive

Re: Embrace TransferDataTo/FromWindow

 

> ...most of our dialogs do not use this.  It will be a non-trivial task to get them all updated.

We could start by getting rid of the Swap Layers… dialog. ;)

https://bugs.launchpad.net/kicad/+bug/1670422 <https://bugs.launchpad.net/kicad/+bug/1670422>




> On 6 Mar 2018, at 21:18, Wayne Stambaugh <stambaughw@xxxxxxxxx> wrote:
> 
> This is already in the UI policy
> 
> http://docs.kicad-pcb.org/doxygen/md_Documentation_development_ui-policy.html#dialogs-xfer
> 
> The problem is a lot of developers relied on the old pattern when
> creating dialogs so most of our dialogs do not use this.  It will be a
> non-trivial task to get them all updated.
> 
> On 3/6/2018 4:08 PM, Jeff Young wrote:
>> We’ve got a lot of dialogs that don’t make use of these.  Not only does it make the code longer and more complex, it also results in bugs (the most recent being that hitting <enter> in the Create Array… dialog does a Cancel, not an OK).
>> 
>> I’ve got to go through most all of the dialogs for the eradication of g_UserUnit in 6.0, so don’t bother to change any existing ones (we’ll just have merge conflicts).
>> 
>> But for new dialogs, please use them.
>> 
>> Cheers,
>> Jeff.
>> _______________________________________________
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp
>> 
> 
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp


References