kicad-developers team mailing list archive

[jp charras <jp.charras@xxxxxxxxxx>]

Le 12/03/2018 à 20:19, Jeff Young a écrit :
> Hi folks,
> 
> I just pushed a change which removes a bunch of unnecessary boilerplate.
> 
> But it occurs to me that maybe it’s necessary with pickier compilers?  Anyway, if someone could try it on Windows and/or Unix that would be great.
> 
> Cheers,
> Jeff.
> 
Hi Jeff,

You fixes can create issues because:

fn.IsFileWritable() ? wxEmptyString : _( " [Read Only]" )
creates issues because wxEmptyString does not return a wxString, but _( " [Read Only]" ) that is a
macro for wxGetTranslation( " [Read Only]" ) returns a wxString

and

title.Printf( _( "Eeschema \u2014 %s" ), GetChars( GetScreen()->GetFileName() ) );

is incorrect because the string inside _() *must be* a ASCII7 string.
This is mandatory for translation tools.


-- 
Jean-Pierre CHARRAS