kicad-developers team mailing list archive

[Jon Evans <jon@xxxxxxxxxxxxx>]

I know what the G means, just wish git describe had an option to disable
it, since it makes copy/paste more tedious.

I think if we had left the tag at rc1, then we'd just have users thinking
they had rc1 when they really have a newer nightly. Better to make a new
tag that doesn't include rcN in it, or at least tries to make it a lot more
obvious that it isn't a RC version despite having those letters in the
string.

-Jon

On Tue, Mar 13, 2018, 11:38 Nick Østergaard <oe.nick@xxxxxxxxx> wrote:

> I think it would have been better if the commit after 5.0.0-rc1 was not
> tagged 5.0.0-rc2-dev. Then the git describe would make more sense. It would
> indicate that it was based on the 5.0.0-rc1 with additional commits and its
> hash.
>
> The g stands for git according to the man page.
> https://git-scm.com/docs/git-describe (search for "-g").
>
> 2018-03-12 15:48 GMT+01:00 Wayne Stambaugh <stambaughw@xxxxxxxxx>:
>
>> On 3/12/2018 10:40 AM, Steven A. Falco wrote:
>> > On 03/12/2018 10:23 AM, Jon Evans wrote:
>> >> I have seen multiple users who run nightlies think they have RC2
>> because they read "5.0.0-rc2" and stop reading after that :-)
>> >> Maybe we should switch the tag back to "5.0-dev" between RC releases?
>> >> I think all of us developers are going to look up the git hash anyway
>> to know exactly when a given version was built, so the "rc2-dev"
>> information isn't super necessary for me at least.
>> >>
>> >> By the way, it's probably annoying to change this because I imagine
>> there are scripts that depend on it, but I wish the git hash didn't have a
>> "g" in front of it, since if I just double-click that portion of the
>> version string I have to manually remove the "g" before pasting it
>> elsewhere to look up the hash.
>> >
>> > I agree that the -rc2 could be confusing.  As to the "g" prefix, that
>> is not present in the Fedora nightlies.  They report more like:
>> >
>> > 5.0.0-rc2-dev-unknown-r12328-8fcbb64a
>>
>> My bad.  I forgot that -unknown is append to the end of the version
>> string when building from a source archive or no git.  Every think
>> appended after that is done by the build script.
>>
>> >
>> > where the r12328 is a sequential number representing the number of
>> commits to date and the 8fcbb64a is the short SHA of the head commit.
>> >
>> >       Steve
>> >
>> >
>> > _______________________________________________
>> > Mailing list: https://launchpad.net/~kicad-developers
>> > Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>> > Unsubscribe : https://launchpad.net/~kicad-developers
>> > More help   : https://help.launchpad.net/ListHelp
>> >
>>
>> _______________________________________________
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp
>>
>
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>