← Back to team overview

kicad-developers team mailing list archive

Re: wxGrid boolean changes

 

Hi Jon,

I implemented (1), (3) and (4) in 6.0.  It was tweaky enough that I don’t recommend it for 5.0 (but I don’t fee strongly). 

You can see my implementation here:  https://git.launchpad.net/~jeyjey/kicad/commit/?h=6.0&id=7dda85fdae21f162bd7413fdceb16e49698f31bf <https://git.launchpad.net/~jeyjey/kicad/commit/?h=6.0&id=7dda85fdae21f162bd7413fdceb16e49698f31bf>.

Cheers,
Jeff.


> On 14 Mar 2018, at 13:50, Jon Evans <jon@xxxxxxxxxxxxx> wrote:
> 
> Hi all,
> 
> I recently (2f86b497) changed the behavior of the wxGrid in the footprint wizard dialog to fix some issues with boolean (checkbox) parameters.
> 
> The default behavior from wxWidgets (at least in 3.0) is buggy in that the update events don't get sent out when you'd expect from the wxGridCellBoolEditor.
> 
> I have found that I can get behavior that makes sense to me by overriding event handlers for the grid itself, but I'd like to make a more generic fix that can be easily portable to other grids, since we will likely have more places to use checkboxes in grids in the future.
> 
> Before I go too far down that path, I wanted to check that the new footprint wizard grid behavior matches with everyone's expectations for how it should work:
> 
> 1) you can toggle the checkbox on/off with a single left click
> 2) you can also toggle with the spacebar if the cell is highlighted
> 3) nothing happens for double click / right click / etc.
> 4) if you click inside the cell (but outside the checkbox) the checkbox is also toggled for convenience
> 
> Thanks,
> Jon
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp


Follow ups

References