kicad-developers team mailing list archive

[hauptmech <hauptmech@xxxxxxxxx>]

On 15 Mar 2018 05:17, "Seth Hillbrand" <seth.hillbrand@xxxxxxxxx> wrote:

Hi hautmech-

Looks good.  Two comments:

- Code style.  There are a couple of small issues: one line is too long,
there should be spaces in parentheses for pad->GetParent()->Remove(pad) and
no space before parentheses in "if ( pad->GetLayerSet()..."


Thanks, I'll fix that.


- We need to handle the case where all items in a module are deleted.
Currently, the code will remove all items except the value and reference.
This means that we can no longer select the module in pcbnew to delete it.
Either we need to fully delete the module when the last selectable item is
removed or we need to keep sufficient information to allow the module to be
selected when the layers are re-enabled.


Is there a preferred approach?

If we don't delete it, then we need to keep the minimum valid info to round
trip to the file (need to check what this is) rather than worry about if it
is selectable, no? UI functionality always lags the internal and external
tools...


Best-
Seth

2018-03-14 2:54 GMT-07:00 hauptmech <hauptmech@xxxxxxxxx>:

> https://bugs.launchpad.net/kicad/+bug/1754049
>
> This patch follows the edict (stated in dialog_layers_setup.cpp) that
> items on a layer that is removed must be deleted.
>
>
>
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>
>