← Back to team overview

kicad-developers team mailing list archive

Re: [PATCH] Fixes in GAL selection filter

 

I’ve always considered a jagged feature envelope a design bug.  I’d support adding the via checkbox.

Cheers,
Jeff.


> On 18 Mar 2018, at 15:31, Jon Evans <jon@xxxxxxxxxxxxx> wrote:
> 
> I tested these patches and they work fine for me.  I also think it's great to add the via filtering checkbox, because I was just in need of that feature on a layout a few days ago...
> But I will defer to Wayne on whether or not this should go in for rc2.
> 
> -Jon
> 
> On Sat, Mar 17, 2018 at 12:32 PM, Andrzej Wolski <awolski.kicad@xxxxxxxxx <mailto:awolski.kicad@xxxxxxxxx>> wrote:
> Hi,
> 
> there are couple problems with selection filter in GAL mode:
> 
> - vias are not filtered, they are always left selected regardless of "Include tracks" checkbox
> - text filtering does not work
> - "Include items on invisible layers" does not work
> 
> Attached patch 0001 addresses these problems.
> 
> In addition, patch 0002 adds "Include vias" checkbox which allows independent filtering of tracks and vias, however, I'm not sure if such change should go into rc2?
> 
> Andrzej
> 
> 
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers <https://launchpad.net/~kicad-developers>
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
> Unsubscribe : https://launchpad.net/~kicad-developers <https://launchpad.net/~kicad-developers>
> More help   : https://help.launchpad.net/ListHelp <https://help.launchpad.net/ListHelp>
> 
> 
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp


Follow ups

References